Re: [PATCH v6 4/5] iwlwifi: convert to use driver data API

From	"Luis R. Rodriguez" <mcgrof@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 4/5] iwlwifi: convert to use driver data API
Date	2017-04-28 03:00 +0200
Message-ID	<tB2qm-8uf-5@gated-at.bofh.it> (permalink)
References	<tqyWC-5f-17@gated-at.bofh.it> <tqyWD-5f-27@gated-at.bofh.it> <tuHyh-1bY-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Apr 10, 2017 at 04:19:12PM +0300, Luca Coelho wrote:
> On Wed, 2017-03-29 at 20:25 -0700, Luis R. Rodriguez wrote:
> > The driver data API provides support for looking for firmware
> > from a specific set of API ranges, so just use that. Since we
> > free the firmware on the callback immediately after consuming it,
> > this also takes avantage of that feature.
> > 
> > Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
> > ---
> 
> Looks fine, with one nitpick.
> 
> 
> >  drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 67 ++++++++++------------------
> >  1 file changed, 23 insertions(+), 44 deletions(-)
> > 
> > diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
> > index be466a074c1d..b6643aa5b344 100644
> > --- a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
> > +++ b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
> 
> [...]
> 
> > @@ -1541,11 +1522,9 @@ struct iwl_drv *iwl_drv_start(struct iwl_trans *trans)
> >  	}
> >  #endif
> >  
> > -	ret = iwl_request_firmware(drv, true);
> > -	if (ret) {
> > -		IWL_ERR(trans, "Couldn't request the fw\n");
> > +	ret = iwl_request_firmware(drv);
> > +	if (ret)
> >  		goto err_fw;
> > -	}
> 
> Why remove the error message here?

The driver data API now has enough semantics even for async requests so that
an error is either always issued or supressed (optional is true), driver errors
then are superfluous on error now.

Let me know if this is OK.

  Luis

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v6 4/5] iwlwifi: convert to use driver data API "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-04-28 03:00 +0200
  Re: [PATCH v6 4/5] iwlwifi: convert to use driver data API Luca Coelho <luca@coelho.fi> - 2017-04-28 14:30 +0200

csiph-web