Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1632455
| From | Larry Finger <Larry.Finger@lwfinger.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/7] staging: rtl8723bs: Macros with complex values should be enclosed in parentheses |
| Date | 2017-04-28 02:30 +0200 |
| Message-ID | <tB1Xk-8eA-5@gated-at.bofh.it> (permalink) |
| References | <tB1ND-8at-3@gated-at.bofh.it> <tB1NE-8at-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 04/27/2017 07:09 PM, Justin Vreeland wrote:
> Signed-off-by: Justin Vreeland <justin@jvreeland.com>
> ---
> drivers/staging/rtl8723bs/hal/odm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723bs/hal/odm.h
> index 0b3541a91548..13c4aebd178e 100644
> --- a/drivers/staging/rtl8723bs/hal/odm.h
> +++ b/drivers/staging/rtl8723bs/hal/odm.h
> @@ -209,7 +209,7 @@ typedef struct _ODM_RATE_ADAPTIVE {
>
> #define AVG_THERMAL_NUM 8
> #define IQK_Matrix_REG_NUM 8
> -#define IQK_Matrix_Settings_NUM 14+24+21 /* Channels_2_4G_NUM + Channels_5G_20M_NUM + Channels_5G */
> +#define IQK_Matrix_Settings_NUM (14+24+21) /* Channels_2_4G_NUM + Channels_5G_20M_NUM + Channels_5G */
You should also put spaces around the plus signs, and fix the lines with more
then 80 columns.
The comment about non-blank commit messages also applies.
Larry
>
> #define DM_Type_ByFW 0
> #define DM_Type_ByDriver 1
>
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH 3/7] staging: rtl8723bs: Macros with complex values should be enclosed in parentheses Justin Vreeland <justin@jvreeland.com> - 2017-04-28 02:20 +0200 Re: [PATCH 3/7] staging: rtl8723bs: Macros with complex values should be enclosed in parentheses Larry Finger <Larry.Finger@lwfinger.net> - 2017-04-28 02:30 +0200
csiph-web