Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1632454

[PATCH 7/7] staging: rtl8723bs: Do not use assignment in if condition

From Justin Vreeland <justin@jvreeland.com>
Newsgroups linux.kernel
Subject [PATCH 7/7] staging: rtl8723bs: Do not use assignment in if condition
Date 2017-04-28 02:30 +0200
Message-ID <tB1Xk-8eA-1@gated-at.bofh.it> (permalink)
References <tB1ND-8at-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Signed-off-by: Justin Vreeland <justin@jvreeland.com>
---
 drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
index cc6eb32c5f71..c189eb575654 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
@@ -609,7 +609,8 @@ s32	rtl8723bs_hal_xmitframe_enqueue(
 	struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
 	s32 err;
 
-	if ((err = rtw_xmitframe_enqueue(padapter, pxmitframe)) != _SUCCESS) {
+	err = rtw_xmitframe_enqueue(padapter, pxmitframe);
+	if (err != _SUCCESS) {
 		rtw_free_xmitframe(pxmitpriv, pxmitframe);
 
 		pxmitpriv->tx_drop++;
-- 
2.12.2

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] staging: rtl8732: Various checkpatch fixes Justin Vreeland <justin@jvreeland.com> - 2017-04-28 02:20 +0200
  [PATCH 2/7] staging: rtl8723bs: Wrap multi-line macros in do-while loop Justin Vreeland <justin@jvreeland.com> - 2017-04-28 02:30 +0200
  [PATCH 7/7] staging: rtl8723bs: Do not use assignment in if condition Justin Vreeland <justin@jvreeland.com> - 2017-04-28 02:30 +0200
  [PATCH 4/7] staging: rtl8723bs: Move braces to same line as conditional Justin Vreeland <justin@jvreeland.com> - 2017-04-28 02:30 +0200
    Re: [PATCH 4/7] staging: rtl8723bs: Move braces to same line as  conditional Larry Finger <Larry.Finger@lwfinger.net> - 2017-04-28 02:30 +0200
      Re: [PATCH 4/7] staging: rtl8723bs: Move braces to same line as  conditional Joe Perches <joe@perches.com> - 2017-04-28 02:30 +0200
  [PATCH 6/7] staging: rtl8723bs: Fix spacing around '<' Justin Vreeland <justin@jvreeland.com> - 2017-04-28 02:30 +0200
  [PATCH 1/7] staging: rtl8723bs: Fix initialization of static variables Justin Vreeland <justin@jvreeland.com> - 2017-04-28 02:30 +0200
  Re: [PATCH 0/7] staging: rtl8732: Various checkpatch fixes Bastien Nocera <hadess@hadess.net> - 2017-04-28 12:00 +0200

csiph-web