Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1631558

[PATCH net-next 11/18] net: dsa: mv88e6xxx: get STU entry on VTU GetNext

From Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Newsgroups linux.kernel
Subject [PATCH net-next 11/18] net: dsa: mv88e6xxx: get STU entry on VTU GetNext
Date 2017-04-26 18:00 +0200
Message-ID <tAxwe-4hS-15@gated-at.bofh.it> (permalink)
References <tAxwd-4hS-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Now that the code reads both VTU and STU data on VTU GetNext operation,
fetch the STU entry data of a VTU entry at the same time.

The STU data bits are masked with the VTU data bits and they are now all
read at the same time a VTU GetNext operation is issued.

Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
---
 drivers/net/dsa/mv88e6xxx/chip.c        |  2 +-
 drivers/net/dsa/mv88e6xxx/global1.h     |  2 ++
 drivers/net/dsa/mv88e6xxx/global1_vtu.c | 22 ++++++++++++++++++++++
 3 files changed, 25 insertions(+), 1 deletion(-)

diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index 5441b05f519b..38c3e047fbf9 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -1292,7 +1292,7 @@ static int _mv88e6xxx_vtu_getnext(struct mv88e6xxx_chip *chip,
 		}
 
 		if (mv88e6xxx_has(chip, MV88E6XXX_FLAG_STU)) {
-			err = mv88e6xxx_g1_vtu_sid_read(chip, &next);
+			err = mv88e6xxx_g1_vtu_stu_get(chip, &next);
 			if (err)
 				return err;
 		}
diff --git a/drivers/net/dsa/mv88e6xxx/global1.h b/drivers/net/dsa/mv88e6xxx/global1.h
index 5d276cc4262b..76b49a3a4701 100644
--- a/drivers/net/dsa/mv88e6xxx/global1.h
+++ b/drivers/net/dsa/mv88e6xxx/global1.h
@@ -72,6 +72,8 @@ int mv88e6xxx_g1_vtu_getnext(struct mv88e6xxx_chip *chip,
 			     struct mv88e6xxx_vtu_entry *entry);
 int mv88e6xxx_g1_vtu_stu_getnext(struct mv88e6xxx_chip *chip,
 				 struct mv88e6xxx_vtu_entry *vtu);
+int mv88e6xxx_g1_vtu_stu_get(struct mv88e6xxx_chip *chip,
+			     struct mv88e6xxx_vtu_entry *vtu);
 int mv88e6xxx_g1_vtu_flush(struct mv88e6xxx_chip *chip);
 
 #endif /* _MV88E6XXX_GLOBAL1_H */
diff --git a/drivers/net/dsa/mv88e6xxx/global1_vtu.c b/drivers/net/dsa/mv88e6xxx/global1_vtu.c
index b7b6e089acfe..4df03000b366 100644
--- a/drivers/net/dsa/mv88e6xxx/global1_vtu.c
+++ b/drivers/net/dsa/mv88e6xxx/global1_vtu.c
@@ -194,6 +194,28 @@ int mv88e6xxx_g1_vtu_stu_getnext(struct mv88e6xxx_chip *chip,
 	return mv88e6xxx_g1_vtu_vid_read(chip, entry);
 }
 
+int mv88e6xxx_g1_vtu_stu_get(struct mv88e6xxx_chip *chip,
+			     struct mv88e6xxx_vtu_entry *vtu)
+{
+	struct mv88e6xxx_vtu_entry stu;
+	int err;
+
+	err = mv88e6xxx_g1_vtu_sid_read(chip, vtu);
+	if (err)
+		return err;
+
+	stu.sid = vtu->sid - 1;
+
+	err = mv88e6xxx_g1_vtu_stu_getnext(chip, &stu);
+	if (err)
+		return err;
+
+	if (stu.sid != vtu->sid || !stu.valid)
+		return -EINVAL;
+
+	return 0;
+}
+
 int mv88e6xxx_g1_vtu_getnext(struct mv88e6xxx_chip *chip,
 			     struct mv88e6xxx_vtu_entry *entry)
 {
-- 
2.12.2

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH net-next 00/18] net: dsa: mv88e6xxx: 802.1s and 88E6390 VTU Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
  [PATCH net-next 02/18] net: dsa: mv88e6xxx: split VTU entry data member Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
    Re: [PATCH net-next 02/18] net: dsa: mv88e6xxx: split VTU entry data  member Andrew Lunn <andrew@lunn.ch> - 2017-04-27 20:30 +0200
  [PATCH net-next 11/18] net: dsa: mv88e6xxx: get STU entry on VTU GetNext Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
    Re: [PATCH net-next 11/18] net: dsa: mv88e6xxx: get STU entry on VTU  GetNext Andrew Lunn <andrew@lunn.ch> - 2017-04-27 22:20 +0200
  [PATCH net-next 13/18] net: dsa: mv88e6xxx: add VTU GetNext operation Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
    Re: [PATCH net-next 13/18] net: dsa: mv88e6xxx: add VTU GetNext  operation Andrew Lunn <andrew@lunn.ch> - 2017-04-28 04:20 +0200
  [PATCH net-next 17/18] net: dsa: mv88e6xxx: support the VTU Page bit Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
    Re: [PATCH net-next 17/18] net: dsa: mv88e6xxx: support the VTU Page  bit Andrew Lunn <andrew@lunn.ch> - 2017-04-28 15:00 +0200
      Re: [PATCH net-next 17/18] net: dsa: mv88e6xxx: support the VTU Page bit Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-28 16:30 +0200
        Re: [PATCH net-next 17/18] net: dsa: mv88e6xxx: support the VTU Page  bit Andrew Lunn <andrew@lunn.ch> - 2017-04-28 17:00 +0200
  [PATCH net-next 04/18] net: dsa: mv88e6xxx: move VTU flush Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
    Re: [PATCH net-next 04/18] net: dsa: mv88e6xxx: move VTU flush Andrew Lunn <andrew@lunn.ch> - 2017-04-27 20:40 +0200
  [PATCH net-next 14/18] net: dsa: mv88e6xxx: add VTU Load/Purge operation Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
    Re: [PATCH net-next 14/18] net: dsa: mv88e6xxx: add VTU Load/Purge  operation Andrew Lunn <andrew@lunn.ch> - 2017-04-28 04:20 +0200
  [PATCH net-next 09/18] net: dsa: mv88e6xxx: move VTU Data accessors Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
    Re: [PATCH net-next 09/18] net: dsa: mv88e6xxx: move VTU Data  accessors Andrew Lunn <andrew@lunn.ch> - 2017-04-27 21:20 +0200
  [PATCH net-next 01/18] net: dsa: mv88e6xxx: add max VID to info Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
    Re: [PATCH net-next 01/18] net: dsa: mv88e6xxx: add max VID to info Andrew Lunn <andrew@lunn.ch> - 2017-04-26 18:10 +0200
  [PATCH net-next 10/18] net: dsa: mv88e6xxx: move STU GetNext operation Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
    Re: [PATCH net-next 10/18] net: dsa: mv88e6xxx: move STU GetNext  operation Andrew Lunn <andrew@lunn.ch> - 2017-04-27 21:50 +0200
  [PATCH net-next 03/18] net: dsa: mv88e6xxx: move VTU Operation accessors Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
    Re: [PATCH net-next 03/18] net: dsa: mv88e6xxx: move VTU Operation  accessors Andrew Lunn <andrew@lunn.ch> - 2017-04-27 20:40 +0200
    Re: [PATCH net-next 03/18] net: dsa: mv88e6xxx: move VTU Operation  accessors Andrew Lunn <andrew@lunn.ch> - 2017-04-27 20:40 +0200
  [PATCH net-next 07/18] net: dsa: mv88e6xxx: move VTU VID accessors Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
    Re: [PATCH net-next 07/18] net: dsa: mv88e6xxx: move VTU VID  accessors Andrew Lunn <andrew@lunn.ch> - 2017-04-27 21:00 +0200
  [PATCH net-next 16/18] net: dsa: mv88e6xxx: simplify VTU entry getter Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:10 +0200
    Re: [PATCH net-next 16/18] net: dsa: mv88e6xxx: simplify VTU entry  getter Andrew Lunn <andrew@lunn.ch> - 2017-04-28 04:30 +0200
  [PATCH net-next 06/18] net: dsa: mv88e6xxx: move VTU SID accessors Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:10 +0200
    Re: [PATCH net-next 06/18] net: dsa: mv88e6xxx: move VTU SID  accessors Andrew Lunn <andrew@lunn.ch> - 2017-04-27 20:40 +0200
  [PATCH net-next 08/18] net: dsa: mv88e6xxx: move generic VTU GetNext Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:10 +0200
    Re: [PATCH net-next 08/18] net: dsa: mv88e6xxx: move generic VTU  GetNext Andrew Lunn <andrew@lunn.ch> - 2017-04-27 21:00 +0200
      Re: [PATCH net-next 08/18] net: dsa: mv88e6xxx: move generic VTU GetNext Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-28 17:10 +0200
  [PATCH net-next 12/18] net: dsa: mv88e6xxx: load STU entry with VTU entry Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:10 +0200
    Re: [PATCH net-next 12/18] net: dsa: mv88e6xxx: load STU entry with  VTU entry Andrew Lunn <andrew@lunn.ch> - 2017-04-28 04:10 +0200
  [PATCH net-next 05/18] net: dsa: mv88e6xxx: move VTU FID accessors Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:10 +0200
    Re: [PATCH net-next 05/18] net: dsa: mv88e6xxx: move VTU FID  accessors Andrew Lunn <andrew@lunn.ch> - 2017-04-27 20:40 +0200
  Re: [PATCH net-next 00/18] net: dsa: mv88e6xxx: 802.1s and 88E6390 VTU Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-01 18:00 +0200
    Re: [PATCH net-next 00/18] net: dsa: mv88e6xxx: 802.1s and 88E6390  VTU David Miller <davem@davemloft.net> - 2017-05-01 18:10 +0200
      Re: [PATCH net-next 00/18] net: dsa: mv88e6xxx: 802.1s and 88E6390  VTU Andrew Lunn <andrew@lunn.ch> - 2017-05-01 18:30 +0200
        Re: [PATCH net-next 00/18] net: dsa: mv88e6xxx: 802.1s and 88E6390 VTU Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-01 19:20 +0200
      Re: [PATCH net-next 00/18] net: dsa: mv88e6xxx: 802.1s and 88E6390 VTU Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-01 18:30 +0200
        Re: [PATCH net-next 00/18] net: dsa: mv88e6xxx: 802.1s and 88E6390  VTU David Miller <davem@davemloft.net> - 2017-05-01 18:30 +0200
          Re: [PATCH net-next 00/18] net: dsa: mv88e6xxx: 802.1s and 88E6390 VTU Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-01 18:40 +0200

csiph-web