Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1632311

Re: [PATCH net-next 02/18] net: dsa: mv88e6xxx: split VTU entry data member

From Andrew Lunn <andrew@lunn.ch>
Newsgroups linux.kernel
Subject Re: [PATCH net-next 02/18] net: dsa: mv88e6xxx: split VTU entry data member
Date 2017-04-27 20:30 +0200
Message-ID <tAWkW-4nM-7@gated-at.bofh.it> (permalink)
References <tAxwd-4hS-3@gated-at.bofh.it> <tAxwd-4hS-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Wed, Apr 26, 2017 at 11:53:20AM -0400, Vivien Didelot wrote:
> VLAN aware Marvell chips can program 802.1Q VLAN membership as well as
> 802.1s per VLAN Spanning Tree state using the same 3 VTU Data registers.
> 
> Some chips such as 88E6185 use different Data registers offsets for
> ports state and membership, and program them in a single operation.
> 
> Other chips such as 88E6352 use the same register layout but program
> them in distinct operations (an indirect table is used for 802.1s.)
> 
> Newer chips such as 88E6390 use the same offsets for both state and
> membership in distinct operations, thus require multiple data accesses.
> 
> To correctly abstract this, split the "data" structure member of
> mv88e6xxx_vtu_entry in two "state" and "member" members, before adding
> VTU support for newer chips.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next 00/18] net: dsa: mv88e6xxx: 802.1s and 88E6390 VTU Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
  [PATCH net-next 02/18] net: dsa: mv88e6xxx: split VTU entry data member Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
    Re: [PATCH net-next 02/18] net: dsa: mv88e6xxx: split VTU entry data  member Andrew Lunn <andrew@lunn.ch> - 2017-04-27 20:30 +0200
  [PATCH net-next 11/18] net: dsa: mv88e6xxx: get STU entry on VTU GetNext Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
    Re: [PATCH net-next 11/18] net: dsa: mv88e6xxx: get STU entry on VTU  GetNext Andrew Lunn <andrew@lunn.ch> - 2017-04-27 22:20 +0200
  [PATCH net-next 13/18] net: dsa: mv88e6xxx: add VTU GetNext operation Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
    Re: [PATCH net-next 13/18] net: dsa: mv88e6xxx: add VTU GetNext  operation Andrew Lunn <andrew@lunn.ch> - 2017-04-28 04:20 +0200
  [PATCH net-next 17/18] net: dsa: mv88e6xxx: support the VTU Page bit Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
    Re: [PATCH net-next 17/18] net: dsa: mv88e6xxx: support the VTU Page  bit Andrew Lunn <andrew@lunn.ch> - 2017-04-28 15:00 +0200
      Re: [PATCH net-next 17/18] net: dsa: mv88e6xxx: support the VTU Page bit Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-28 16:30 +0200
        Re: [PATCH net-next 17/18] net: dsa: mv88e6xxx: support the VTU Page  bit Andrew Lunn <andrew@lunn.ch> - 2017-04-28 17:00 +0200
  [PATCH net-next 04/18] net: dsa: mv88e6xxx: move VTU flush Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
    Re: [PATCH net-next 04/18] net: dsa: mv88e6xxx: move VTU flush Andrew Lunn <andrew@lunn.ch> - 2017-04-27 20:40 +0200
  [PATCH net-next 14/18] net: dsa: mv88e6xxx: add VTU Load/Purge operation Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
    Re: [PATCH net-next 14/18] net: dsa: mv88e6xxx: add VTU Load/Purge  operation Andrew Lunn <andrew@lunn.ch> - 2017-04-28 04:20 +0200
  [PATCH net-next 09/18] net: dsa: mv88e6xxx: move VTU Data accessors Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
    Re: [PATCH net-next 09/18] net: dsa: mv88e6xxx: move VTU Data  accessors Andrew Lunn <andrew@lunn.ch> - 2017-04-27 21:20 +0200
  [PATCH net-next 01/18] net: dsa: mv88e6xxx: add max VID to info Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
    Re: [PATCH net-next 01/18] net: dsa: mv88e6xxx: add max VID to info Andrew Lunn <andrew@lunn.ch> - 2017-04-26 18:10 +0200
  [PATCH net-next 10/18] net: dsa: mv88e6xxx: move STU GetNext operation Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
    Re: [PATCH net-next 10/18] net: dsa: mv88e6xxx: move STU GetNext  operation Andrew Lunn <andrew@lunn.ch> - 2017-04-27 21:50 +0200
  [PATCH net-next 03/18] net: dsa: mv88e6xxx: move VTU Operation accessors Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
    Re: [PATCH net-next 03/18] net: dsa: mv88e6xxx: move VTU Operation  accessors Andrew Lunn <andrew@lunn.ch> - 2017-04-27 20:40 +0200
    Re: [PATCH net-next 03/18] net: dsa: mv88e6xxx: move VTU Operation  accessors Andrew Lunn <andrew@lunn.ch> - 2017-04-27 20:40 +0200
  [PATCH net-next 07/18] net: dsa: mv88e6xxx: move VTU VID accessors Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
    Re: [PATCH net-next 07/18] net: dsa: mv88e6xxx: move VTU VID  accessors Andrew Lunn <andrew@lunn.ch> - 2017-04-27 21:00 +0200
  [PATCH net-next 16/18] net: dsa: mv88e6xxx: simplify VTU entry getter Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:10 +0200
    Re: [PATCH net-next 16/18] net: dsa: mv88e6xxx: simplify VTU entry  getter Andrew Lunn <andrew@lunn.ch> - 2017-04-28 04:30 +0200
  [PATCH net-next 06/18] net: dsa: mv88e6xxx: move VTU SID accessors Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:10 +0200
    Re: [PATCH net-next 06/18] net: dsa: mv88e6xxx: move VTU SID  accessors Andrew Lunn <andrew@lunn.ch> - 2017-04-27 20:40 +0200
  [PATCH net-next 08/18] net: dsa: mv88e6xxx: move generic VTU GetNext Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:10 +0200
    Re: [PATCH net-next 08/18] net: dsa: mv88e6xxx: move generic VTU  GetNext Andrew Lunn <andrew@lunn.ch> - 2017-04-27 21:00 +0200
      Re: [PATCH net-next 08/18] net: dsa: mv88e6xxx: move generic VTU GetNext Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-28 17:10 +0200
  [PATCH net-next 12/18] net: dsa: mv88e6xxx: load STU entry with VTU entry Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:10 +0200
    Re: [PATCH net-next 12/18] net: dsa: mv88e6xxx: load STU entry with  VTU entry Andrew Lunn <andrew@lunn.ch> - 2017-04-28 04:10 +0200
  [PATCH net-next 05/18] net: dsa: mv88e6xxx: move VTU FID accessors Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:10 +0200
    Re: [PATCH net-next 05/18] net: dsa: mv88e6xxx: move VTU FID  accessors Andrew Lunn <andrew@lunn.ch> - 2017-04-27 20:40 +0200
  Re: [PATCH net-next 00/18] net: dsa: mv88e6xxx: 802.1s and 88E6390 VTU Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-01 18:00 +0200
    Re: [PATCH net-next 00/18] net: dsa: mv88e6xxx: 802.1s and 88E6390  VTU David Miller <davem@davemloft.net> - 2017-05-01 18:10 +0200
      Re: [PATCH net-next 00/18] net: dsa: mv88e6xxx: 802.1s and 88E6390  VTU Andrew Lunn <andrew@lunn.ch> - 2017-05-01 18:30 +0200
        Re: [PATCH net-next 00/18] net: dsa: mv88e6xxx: 802.1s and 88E6390 VTU Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-01 19:20 +0200
      Re: [PATCH net-next 00/18] net: dsa: mv88e6xxx: 802.1s and 88E6390 VTU Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-01 18:30 +0200
        Re: [PATCH net-next 00/18] net: dsa: mv88e6xxx: 802.1s and 88E6390  VTU David Miller <davem@davemloft.net> - 2017-05-01 18:30 +0200
          Re: [PATCH net-next 00/18] net: dsa: mv88e6xxx: 802.1s and 88E6390 VTU Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-01 18:40 +0200

csiph-web