Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1632402

Re: [PATCH] kexec: allocate buffer in top-down, if specified, correctly

Show all headers | View raw

Hello,

Am Mittwoch, 26. April 2017, 17:22:09 BRT schrieb AKASHI Takahiro:
> The current kexec_locate_mem_hole(kbuf.top_down == 1) stops searching at
> the first memory region that has enough space for requested size even if
> some of higher regions may also have.

kexec_locate_mem_hole expects arch_kexec_walk_mem to walk memory from top to 
bottom if top_down is true. That is what powerpc's version does.

Isn't it possible to walk resources from top to bottom?

> This behavior is not consistent with locate_hole(hole_end == -1) function
> of kexec-tools.
> 
> This patch fixes the bug, going though all the memory regions anyway.

This patch would break powerpc, because at the end of the memory walk kbuf 
would have the lowest memory hole.

If it's not possible to walk resources in reverse order, then this patch needs 
to change powerpc to always walk memory from bottom to top.

-- 
Thiago Jung Bauermann
IBM Linux Technology Center

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] kexec: allocate buffer in top-down, if specified, correctly AKASHI Takahiro <takahiro.akashi@linaro.org> - 2017-04-26 10:30 +0200
  Re: [PATCH] kexec: allocate buffer in top-down, if specified, correctly Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com> - 2017-04-28 00:10 +0200
    Re: [PATCH] kexec: allocate buffer in top-down, if specified,  correctly AKASHI Takahiro <takahiro.akashi@linaro.org> - 2017-04-28 03:00 +0200
      Re: [PATCH] kexec: allocate buffer in top-down, if specified,  correctly Dave Young <dyoung@redhat.com> - 2017-04-28 07:30 +0200
      Re: [PATCH] kexec: allocate buffer in top-down, if specified,  correctly Dave Young <dyoung@redhat.com> - 2017-04-28 07:30 +0200
      Re: [PATCH] kexec: allocate buffer in top-down, if specified, correctly Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com> - 2017-04-28 21:40 +0200
  Re: [PATCH] kexec: allocate buffer in top-down, if specified,  correctly Dave Young <dyoung@redhat.com> - 2017-04-28 06:50 +0200

csiph-web