Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1632151

Re: [PATCH v2] gpiolib: Add stubs for gpiod lookup table interface

From Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2] gpiolib: Add stubs for gpiod lookup table interface
Date 2017-04-27 16:50 +0200
Message-ID <tASU2-1Wr-15@gated-at.bofh.it> (permalink)
References <tALzc-5ht-15@gated-at.bofh.it> <tAShj-1ET-3@gated-at.bofh.it> <tASAG-1Ma-13@gated-at.bofh.it> <tASAG-1Ma-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Apr 27, 2017 at 5:29 PM, Anatolij Gustschin <agust@denx.de> wrote:
> On Thu, 27 Apr 2017 16:25:34 +0200
> Anatolij Gustschin agust@denx.de wrote:
>
>>On Thu, 27 Apr 2017 17:07:23 +0300
>>Andy Shevchenko andy.shevchenko@gmail.com wrote:
> ...
>>>static inline void gpiod_add_lookup_table(struct gpiod_lookup_table *table) {}
>>>static inline void gpiod_remove_lookup_table(struct gpiod_lookup_table
>>>*table) {}
>>>#endif /* !GPIOLIB */
>>>
>>>P.S. please notice how I put the stubs. It would be good to keep them
>>>in two lines.
>>
>>this will exceed 80 char line limit.

Not for many (unimportant) symbols.

> I'll go with
>
> static inline
> void gpiod_add_lookup_table(struct gpiod_lookup_table *table) {}
>
> static inline
> void gpiod_remove_lookup_table(struct gpiod_lookup_table *table) {}
>
> Is it okay?

Whatever Linus prefers. I'm fine with either.

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2] gpiolib: Add stubs for gpiod lookup table interface Anatolij Gustschin <agust@denx.de> - 2017-04-27 09:00 +0200
  Re: [PATCH v2] gpiolib: Add stubs for gpiod lookup table interface Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-27 16:10 +0200
    Re: [PATCH v2] gpiolib: Add stubs for gpiod lookup table interface Anatolij Gustschin <agust@denx.de> - 2017-04-27 16:30 +0200
      Re: [PATCH v2] gpiolib: Add stubs for gpiod lookup table interface Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-27 16:50 +0200
    Re: [PATCH v2] gpiolib: Add stubs for gpiod lookup table interface Anatolij Gustschin <agust@denx.de> - 2017-04-27 16:30 +0200

csiph-web