Re: [PATCH v2] gpiolib: Add stubs for gpiod lookup table interface

From	Anatolij Gustschin <agust@denx.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] gpiolib: Add stubs for gpiod lookup table interface
Date	2017-04-27 16:30 +0200
Message-ID	<tASAG-1Ma-13@gated-at.bofh.it> (permalink)
References	<tALzc-5ht-15@gated-at.bofh.it> <tAShj-1ET-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 27 Apr 2017 17:07:23 +0300
Andy Shevchenko andy.shevchenko@gmail.com wrote:

>On Thu, Apr 27, 2017 at 9:52 AM, Anatolij Gustschin <agust@denx.de> wrote:
>> Add stubs for gpiod_add_lookup_table() and gpiod_remove_lookup_table()
>> for the !GPIOLIB case to prevent build errors. Also add prototypes.
>>
>> Signed-off-by: Anatolij Gustschin <agust@denx.de>
>> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>  
>
>Oh, has to take my tag back. See below why.
>
>
>> --- a/include/linux/gpio/consumer.h
>> +++ b/include/linux/gpio/consumer.h  
>
>It is already defined in machine.h.
>
>What you basically need is to add stubs for !GPIOLIB case
>
>#ifdef ...
>...existing prototypes...
>#else /* GPIOLIB */
>static inline void gpiod_add_lookup_table(struct gpiod_lookup_table *table) {}
>static inline void gpiod_remove_lookup_table(struct gpiod_lookup_table
>*table) {}
>#endif /* !GPIOLIB */
>
>P.S. please notice how I put the stubs. It would be good to keep them
>in two lines.

this will exceed 80 char line limit.

Thanks,

Anatolij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] gpiolib: Add stubs for gpiod lookup table interface Anatolij Gustschin <agust@denx.de> - 2017-04-27 09:00 +0200
  Re: [PATCH v2] gpiolib: Add stubs for gpiod lookup table interface Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-27 16:10 +0200
    Re: [PATCH v2] gpiolib: Add stubs for gpiod lookup table interface Anatolij Gustschin <agust@denx.de> - 2017-04-27 16:30 +0200
      Re: [PATCH v2] gpiolib: Add stubs for gpiod lookup table interface Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-27 16:50 +0200
    Re: [PATCH v2] gpiolib: Add stubs for gpiod lookup table interface Anatolij Gustschin <agust@denx.de> - 2017-04-27 16:30 +0200

csiph-web