Groups > linux.kernel > #1632097

Re: [PATCH v5 01/10] arm64: allwinner: a64: enable RSB on A64

From	Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 01/10] arm64: allwinner: a64: enable RSB on A64
Date	2017-04-27 15:30 +0200
Message-ID	<tAREC-1aB-19@gated-at.bofh.it> (permalink)
References	<tAx3c-46S-5@gated-at.bofh.it> <tAx3d-46S-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Apr 26, 2017 at 11:20:14PM +0800, Icenowy Zheng wrote:
> Allwinner A64 have a RSB controller like the one on A23/A33 SoCs.
> 
> Add it and its pinmux.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> Acked-by: Chen-Yu Tsai <wens@csie.org>
> ---
> Changes in v2:
> - Removed bonus properties in pio node.
> - Added Chen-Yu's ACK.
> 
>  arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> index c7f669f5884f..05ec9fc5e81f 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> @@ -422,6 +422,25 @@
>  			#gpio-cells = <3>;
>  			interrupt-controller;
>  			#interrupt-cells = <3>;
> +
> +			r_rsb_pins: rsb@0 {
> +				pins = "PL0", "PL1";
> +				function = "s_rsb";
> +			};
> +		};
> +
> +		r_rsb: rsb@1f03400 {
> +			compatible = "allwinner,sun8i-a23-rsb";
> +			reg = <0x01f03400 0x400>;
> +			interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&r_ccu 6>;

Please use the defines here..

> +			clock-frequency = <3000000>;
> +			resets = <&r_ccu 2>;

And here.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Thread

[PATCH v5 01/10] arm64: allwinner: a64: enable RSB on A64 Icenowy Zheng <icenowy@aosc.io> - 2017-04-26 17:30 +0200
  Re: [PATCH v5 01/10] arm64: allwinner: a64: enable RSB on A64 Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-04-27 15:30 +0200
    Re: [PATCH v5 01/10] arm64: allwinner: a64: enable RSB on A64 icenowy@aosc.io - 2017-04-27 20:20 +0200
      Re: [PATCH v5 01/10] arm64: allwinner: a64: enable RSB on A64 Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-05-02 13:30 +0200

csiph-web