Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1632096

Re: hwmon-NCT: Fine-tuning for four function implementations

Show all headers | View raw

Am 27.04.2017 um 14:50 schrieb Jean Delvare:
> On Thu, 27 Apr 2017 11:27:21 +0200, SF Markus Elfring wrote:
>> From: Markus Elfring <elfring@users.sourceforge.net>
>> Date: Thu, 27 Apr 2017 11:18:22 +0200
>>
>> A few update suggestions were taken into account
>> from static source code analysis.
>>
>> Markus Elfring (4):
>>   Use devm_kcalloc() in nct6683_create_attr_group()
>>   Adjust five checks for null pointers
>>   Use devm_kcalloc() in nct6775_create_attr_group()
>>   Adjust seven checks for null pointers
>>
>>  drivers/hwmon/nct6683.c | 15 +++++++--------
>>  drivers/hwmon/nct6775.c | 19 +++++++++----------
>>  2 files changed, 16 insertions(+), 18 deletions(-)
> 
> You have proven in the past on various lists that 1* you have no
> understanding about the changes you are proposing

You are right in the sense that my knowledge is still incomplete
in some areas.


> and 2* you have no skills to discuss any problem that could be found
> in your patches.

But I disagree to this view. My skills might not fit to your expectations
at the moment. But I hope that there are further opportunities to resolve
remaining software development concerns.

Regards,
Markus

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] hwmon-NCT: Fine-tuning for four function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-27 11:30 +0200
  [PATCH 4/4] hwmon-nct6775: Adjust seven checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-27 11:40 +0200
  [PATCH 1/4] hwmon-nct6683: Use devm_kcalloc() in  nct6683_create_attr_group() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-27 11:40 +0200
  [PATCH 2/4] hwmon-nct6683: Adjust five checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-27 11:40 +0200
  [PATCH 3/4] hwmon-nct6775: Use devm_kcalloc() in  nct6775_create_attr_group() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-27 11:40 +0200
  Re: [PATCH 0/4] hwmon-NCT: Fine-tuning for four function  implementations Jean Delvare <jdelvare@suse.de> - 2017-04-27 15:00 +0200
    Re: hwmon-NCT: Fine-tuning for four function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-27 15:30 +0200

csiph-web