Groups > linux.kernel > #1631948

Re: [PATCH 1/2] wcn36xx: Pass used skb to ieee80211_tx_status()

From	Johannes Berg <johannes@sipsolutions.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] wcn36xx: Pass used skb to ieee80211_tx_status()
Date	2017-04-27 10:30 +0200
Message-ID	<tAMYh-6lN-5@gated-at.bofh.it> (permalink)
References	<tADii-8v0-13@gated-at.bofh.it> <tAMYh-6lN-7@gated-at.bofh.it> <tADii-8v0-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> @@ -371,7 +371,7 @@ static void reap_tx_dxes(struct wcn36xx *wcn,
> struct wcn36xx_dxe_ch *ch)
>  			info = IEEE80211_SKB_CB(ctl->skb);
>  			if (!(info->flags &
> IEEE80211_TX_CTL_REQ_TX_STATUS)) {
>  				/* Keep frame until TX status comes
> */
> -				ieee80211_free_txskb(wcn->hw, ctl-
> >skb);
> +				ieee80211_tx_status(wcn->hw, ctl-
> >skb);
> 

I don't think this is a good idea. This code intentionally checked if
TX status was requested, and if not then it doesn't go to the effort of
building it.

As it is with your patch, it'll go and report the TX status without any
TX status information - which is handled in wcn36xx_dxe_tx_ack_ind()
for those frames needing it.

johannes

Thread

[PATCH 1/2] wcn36xx: Pass used skb to ieee80211_tx_status() Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-04-27 00:10 +0200
  [PATCH 2/2] arm64: dts: apq8016-sbc: Correct WLAN LED default-trigger Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-04-27 00:10 +0200
  Re: [PATCH 1/2] wcn36xx: Pass used skb to ieee80211_tx_status() Johannes Berg <johannes@sipsolutions.net> - 2017-04-27 10:30 +0200
    Re: [PATCH 1/2] wcn36xx: Pass used skb to ieee80211_tx_status() Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-04-29 01:50 +0200
      Re: [PATCH 1/2] wcn36xx: Pass used skb to ieee80211_tx_status() Kalle Valo <kvalo@qca.qualcomm.com> - 2017-05-04 15:20 +0200

csiph-web