Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1630296
| From | Icenowy Zheng <icenowy@aosc.io> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [linux-sunxi] Re: [PATCH v4 07/10] mfd: axp20x: add axp20x-regulator cell for AXP803 |
| Date | 2017-04-25 10:40 +0200 |
| Message-ID | <tA4aR-2hp-9@gated-at.bofh.it> (permalink) |
| References | <tzOIN-JE-1@gated-at.bofh.it> <tzOIP-JE-27@gated-at.bofh.it> <tA3y9-1M8-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
于 2017年4月25日 GMT+08:00 下午3:57:17, Lee Jones <lee.jones@linaro.org> 写到:
>On Tue, 25 Apr 2017, Icenowy Zheng wrote:
>
>> As axp20x-regulator now supports AXP803, add a cell for it.
>>
>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>> Acked-by: Chen-Yu Tsai <wens@csie.org>
>> ---
>> Changes in v4:
>> - Added a trailing comma for new cell, for easier further cell
>addition.
>> Changes in v3:
>> - Make the new cell one-liner.
>>
>> drivers/mfd/axp20x.c | 3 ++-
>> drivers/regulator/axp20x-regulator.c | 6 +++---
>
>These 2 changes are orthogonal, thus there is no reason to send them
>bundled into a single patch. Doing so complicates things greatly.
>Please resubmit the two changes separately, so that they may be
>absorbed by our respective subsystems.
Yes. As Chen-Yu said, I wrongly squashed the regulator renaming patch here...
It should be squashed into the regulator patch.
Sorry for it.
>
>> 2 files changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
>> index 1dc6235778eb..917b6ddc4f15 100644
>> --- a/drivers/mfd/axp20x.c
>> +++ b/drivers/mfd/axp20x.c
>> @@ -848,7 +848,8 @@ static struct mfd_cell axp803_cells[] = {
>> .name = "axp20x-pek",
>> .num_resources = ARRAY_SIZE(axp803_pek_resources),
>> .resources = axp803_pek_resources,
>> - }
>> + },
>> + { .name = "axp20x-regulator" },
>> };
>>
>> static struct mfd_cell axp806_cells[] = {
>> diff --git a/drivers/regulator/axp20x-regulator.c
>b/drivers/regulator/axp20x-regulator.c
>> index 9356ec8a9a1f..e2608fe770b9 100644
>> --- a/drivers/regulator/axp20x-regulator.c
>> +++ b/drivers/regulator/axp20x-regulator.c
>> @@ -311,13 +311,13 @@ static const struct regulator_desc
>axp803_regulators[] = {
>> AXP803_FLDO1_V_OUT, 0x0f, AXP22X_PWR_OUT_CTRL3, BIT(2)),
>> AXP_DESC(AXP803, FLDO2, "fldo2", "fldoin", 700, 1450, 50,
>> AXP803_FLDO2_V_OUT, 0x0f, AXP22X_PWR_OUT_CTRL3, BIT(3)),
>> - AXP_DESC_IO(AXP803, LDO_IO0, "ldo_io0", "ips", 700, 3300, 100,
>> + AXP_DESC_IO(AXP803, LDO_IO0, "ldo-io0", "ips", 700, 3300, 100,
>> AXP22X_LDO_IO0_V_OUT, 0x1f, AXP20X_GPIO0_CTRL, 0x07,
>> AXP22X_IO_ENABLED, AXP22X_IO_DISABLED),
>> - AXP_DESC_IO(AXP803, LDO_IO1, "ldo_io1", "ips", 700, 3300, 100,
>> + AXP_DESC_IO(AXP803, LDO_IO1, "ldo-io1", "ips", 700, 3300, 100,
>> AXP22X_LDO_IO1_V_OUT, 0x1f, AXP20X_GPIO1_CTRL, 0x07,
>> AXP22X_IO_ENABLED, AXP22X_IO_DISABLED),
>> - AXP_DESC_FIXED(AXP803, RTC_LDO, "rtc_ldo", "ips", 3000),
>> + AXP_DESC_FIXED(AXP803, RTC_LDO, "rtc-ldo", "ips", 3000),
>> };
>>
>> static const struct regulator_linear_range axp806_dcdca_ranges[] = {
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v4 00/10] AXP803 PMIC support for Pine64 Icenowy Zheng <icenowy@aosc.io> - 2017-04-24 18:10 +0200
[PATCH v4 03/10] irqchip/sunxi-nmi: add support for the NMI in A64 R_INTC Icenowy Zheng <icenowy@aosc.io> - 2017-04-24 18:10 +0200
Re: [PATCH v4 03/10] irqchip/sunxi-nmi: add support for the NMI in A64 R_INTC icenowy@aosc.io - 2017-04-24 18:20 +0200
[PATCH v4 07/10] mfd: axp20x: add axp20x-regulator cell for AXP803 Icenowy Zheng <icenowy@aosc.io> - 2017-04-24 18:10 +0200
Re: [linux-sunxi] [PATCH v4 07/10] mfd: axp20x: add axp20x-regulator cell for AXP803 Chen-Yu Tsai <wens@csie.org> - 2017-04-25 04:20 +0200
Re: [linux-sunxi] [PATCH v4 07/10] mfd: axp20x: add axp20x-regulator cell for AXP803 icenowy@aosc.io - 2017-04-25 07:50 +0200
Re: [PATCH v4 07/10] mfd: axp20x: add axp20x-regulator cell for AXP803 Lee Jones <lee.jones@linaro.org> - 2017-04-25 10:00 +0200
Re: [linux-sunxi] Re: [PATCH v4 07/10] mfd: axp20x: add axp20x-regulator cell for AXP803 Icenowy Zheng <icenowy@aosc.io> - 2017-04-25 10:40 +0200
[PATCH v4 08/10] arm64: allwinner: a64: add DTSI file for AXP803 PMIC Icenowy Zheng <icenowy@aosc.io> - 2017-04-24 18:10 +0200
[PATCH v4 10/10] arm64: allwinner: a64: enable Wi-Fi for Pine64 Icenowy Zheng <icenowy@aosc.io> - 2017-04-24 18:10 +0200
[PATCH v4 09/10] arm64: allwinner: a64: enable AXP803 regulators for Pine64 Icenowy Zheng <icenowy@aosc.io> - 2017-04-24 18:10 +0200
Re: [linux-sunxi] [PATCH v4 09/10] arm64: allwinner: a64: enable AXP803 regulators for Pine64 Andre Przywara <andre.przywara@arm.com> - 2017-04-25 11:30 +0200
Re: [linux-sunxi] [PATCH v4 09/10] arm64: allwinner: a64: enable AXP803 regulators for Pine64 Icenowy Zheng <icenowy@aosc.io> - 2017-04-25 11:30 +0200
[PATCH v4 02/10] irqchip/sunxi-nmi: add A64 R_INTC to the binding doc Icenowy Zheng <icenowy@aosc.io> - 2017-04-24 18:10 +0200
[PATCH v4 01/10] arm64: allwinner: a64: enable RSB on A64 Icenowy Zheng <icenowy@aosc.io> - 2017-04-24 18:10 +0200
[PATCH v4 04/10] arm64: allwinner: a64: add NMI (R_INTC) controller on A64 Icenowy Zheng <icenowy@aosc.io> - 2017-04-24 18:10 +0200
[PATCH v4 06/10] regulator: axp20x-regulator: add support for AXP803 Icenowy Zheng <icenowy@aosc.io> - 2017-04-24 18:10 +0200
[PATCH v4 05/10] arm64: allwinner: a64: add AXP803 node to Pine64 device tree Icenowy Zheng <icenowy@aosc.io> - 2017-04-24 18:10 +0200
csiph-web