Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1630331

Re: [linux-sunxi] [PATCH v4 09/10] arm64: allwinner: a64: enable AXP803 regulators for Pine64

From Andre Przywara <andre.przywara@arm.com>
Newsgroups linux.kernel
Subject Re: [linux-sunxi] [PATCH v4 09/10] arm64: allwinner: a64: enable AXP803 regulators for Pine64
Date 2017-04-25 11:30 +0200
Message-ID <tA4Xf-2Ow-9@gated-at.bofh.it> (permalink)
References <tzOIN-JE-1@gated-at.bofh.it> <tzOIP-JE-33@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi,

On 24/04/17 17:01, Icenowy Zheng wrote:
> Add support of AXP803 regulators in the Pine64 device tree, in order to
> enable many future functionalities, e.g. Wi-Fi.

In general that's quite some code to just achieve some device power
plane switching, but that's another discussion, I guess ;-)

To me this patch here like a lot of churn to be duplicated in each
board's DT.
Can't we provide some sane defaults, either in axp803.dtsi or in an
extra file (allwinner-ref-axp803.dtsi?), and only overwrite them in a
board's DT if a board deviates?
Because it seems like many boards are actually based on some Allwinner
reference design and use very similar, if not identical settings.

Also one thing below ...

> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
>  .../arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 109 +++++++++++++++++++++
>  1 file changed, 109 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
> index 3e1b44292534..abc1879e91f2 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
> @@ -106,6 +106,115 @@
>  	};
>  };
>  
> +#include "axp803.dtsi"
> +
> +&reg_aldo1 {
> +	regulator-min-microvolt = <2800000>;
> +	regulator-max-microvolt = <2800000>;
> +	regulator-name = "vcc-csi";
> +};
> +
> +&reg_aldo2 {
> +	regulator-always-on;
> +	regulator-min-microvolt = <1800000>;
> +	regulator-max-microvolt = <3300000>;
> +	regulator-name = "vcc-pl";
> +};
> +
> +&reg_aldo3 {
> +	regulator-always-on;
> +	regulator-min-microvolt = <2700000>;
> +	regulator-max-microvolt = <3300000>;
> +	regulator-name = "vcc-pll-avcc";
> +};
> +
> +&reg_dc1sw {
> +	regulator-name = "vcc-phy";
> +};
> +
> +&reg_dcdc1 {
> +	regulator-always-on;
> +	regulator-min-microvolt = <3300000>;
> +	regulator-max-microvolt = <3300000>;
> +	regulator-name = "vcc-3v3";
> +};
> +
> +&reg_dcdc2 {
> +	regulator-always-on;
> +	regulator-min-microvolt = <1000000>;
> +	regulator-max-microvolt = <1300000>;
> +	regulator-name = "vdd-cpux";
> +};
> +
> +/* DCDC3 is polyphased with DCDC2 */
> +
> +&reg_dcdc5 {
> +	regulator-always-on;
> +	regulator-min-microvolt = <1500000>;
> +	regulator-max-microvolt = <1500000>;

On the Pine64 there is DDR3L DRAM, running at 1.35V.

Cheers,
Andre.


> +	regulator-name = "vcc-dram";
> +};
> +
> +&reg_dcdc6 {
> +	regulator-always-on;
> +	regulator-min-microvolt = <1100000>;
> +	regulator-max-microvolt = <1100000>;
> +	regulator-name = "vdd-sys";
> +};
> +
> +&reg_dldo1 {
> +	regulator-min-microvolt = <3300000>;
> +	regulator-max-microvolt = <3300000>;
> +	regulator-name = "vcc-hdmi";
> +};
> +
> +&reg_dldo2 {
> +	regulator-min-microvolt = <3300000>;
> +	regulator-max-microvolt = <3300000>;
> +	regulator-name = "vcc-mipi";
> +};
> +
> +&reg_dldo3 {
> +	regulator-min-microvolt = <3300000>;
> +	regulator-max-microvolt = <3300000>;
> +	regulator-name = "avdd-csi";
> +};
> +
> +&reg_dldo4 {
> +	regulator-min-microvolt = <3300000>;
> +	regulator-max-microvolt = <3300000>;
> +	regulator-name = "vcc-wifi";
> +};
> +
> +&reg_eldo1 {
> +	regulator-min-microvolt = <1800000>;
> +	regulator-max-microvolt = <1800000>;
> +	regulator-name = "cpvdd";
> +};
> +
> +&reg_eldo3 {
> +	regulator-min-microvolt = <1800000>;
> +	regulator-max-microvolt = <1800000>;
> +	regulator-name = "vdd-1v8-csi";
> +};
> +
> +&reg_fldo1 {
> +	regulator-min-microvolt = <1200000>;
> +	regulator-max-microvolt = <1200000>;
> +	regulator-name = "vcc-1v2-hsic";
> +};
> +
> +&reg_fldo2 {
> +	regulator-always-on;
> +	regulator-min-microvolt = <1100000>;
> +	regulator-max-microvolt = <1100000>;
> +	regulator-name = "vdd-cpus";
> +};
> +
> +&reg_rtc_ldo {
> +	regulator-name = "vcc-rtc";
> +};
> +
>  &uart0 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&uart0_pins_a>;
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 00/10] AXP803 PMIC support for Pine64 Icenowy Zheng <icenowy@aosc.io> - 2017-04-24 18:10 +0200
  [PATCH v4 03/10] irqchip/sunxi-nmi: add support for the NMI in A64 R_INTC Icenowy Zheng <icenowy@aosc.io> - 2017-04-24 18:10 +0200
    Re: [PATCH v4 03/10] irqchip/sunxi-nmi: add support for the NMI in  A64 R_INTC icenowy@aosc.io - 2017-04-24 18:20 +0200
  [PATCH v4 07/10] mfd: axp20x: add axp20x-regulator cell for AXP803 Icenowy Zheng <icenowy@aosc.io> - 2017-04-24 18:10 +0200
    Re: [linux-sunxi] [PATCH v4 07/10] mfd: axp20x: add axp20x-regulator  cell for AXP803 Chen-Yu Tsai <wens@csie.org> - 2017-04-25 04:20 +0200
      Re: [linux-sunxi] [PATCH v4 07/10] mfd: axp20x: add axp20x-regulator  cell for AXP803 icenowy@aosc.io - 2017-04-25 07:50 +0200
    Re: [PATCH v4 07/10] mfd: axp20x: add axp20x-regulator cell for  AXP803 Lee Jones <lee.jones@linaro.org> - 2017-04-25 10:00 +0200
      Re: [linux-sunxi] Re: [PATCH v4 07/10] mfd: axp20x: add axp20x-regulator cell for AXP803 Icenowy Zheng <icenowy@aosc.io> - 2017-04-25 10:40 +0200
  [PATCH v4 08/10] arm64: allwinner: a64: add DTSI file for AXP803 PMIC Icenowy Zheng <icenowy@aosc.io> - 2017-04-24 18:10 +0200
  [PATCH v4 10/10] arm64: allwinner: a64: enable Wi-Fi for Pine64 Icenowy Zheng <icenowy@aosc.io> - 2017-04-24 18:10 +0200
  [PATCH v4 09/10] arm64: allwinner: a64: enable AXP803 regulators for Pine64 Icenowy Zheng <icenowy@aosc.io> - 2017-04-24 18:10 +0200
    Re: [linux-sunxi] [PATCH v4 09/10] arm64: allwinner: a64: enable  AXP803 regulators for Pine64 Andre Przywara <andre.przywara@arm.com> - 2017-04-25 11:30 +0200
      Re: [linux-sunxi] [PATCH v4 09/10] arm64: allwinner: a64: enable AXP803 regulators for Pine64 Icenowy Zheng <icenowy@aosc.io> - 2017-04-25 11:30 +0200
  [PATCH v4 02/10] irqchip/sunxi-nmi: add A64 R_INTC to the binding doc Icenowy Zheng <icenowy@aosc.io> - 2017-04-24 18:10 +0200
  [PATCH v4 01/10] arm64: allwinner: a64: enable RSB on A64 Icenowy Zheng <icenowy@aosc.io> - 2017-04-24 18:10 +0200
  [PATCH v4 04/10] arm64: allwinner: a64: add NMI (R_INTC) controller on A64 Icenowy Zheng <icenowy@aosc.io> - 2017-04-24 18:10 +0200
  [PATCH v4 06/10] regulator: axp20x-regulator: add support for AXP803 Icenowy Zheng <icenowy@aosc.io> - 2017-04-24 18:10 +0200
  [PATCH v4 05/10] arm64: allwinner: a64: add AXP803 node to Pine64 device tree Icenowy Zheng <icenowy@aosc.io> - 2017-04-24 18:10 +0200

csiph-web