Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1577852

Re: [GIT PULL] PCI fixes for v4.10

Show all headers | View raw

Thanks Bjorn,

With the fixes below, managed add remove via sysfs seems to work on my
SKX system. 

I'm not familiar with runtime PM aspects, just started looking into it 
after this one. There seems some interactions with ASPM and how we handle 
devices that support ARI for e.g.

For hotplug, we have a good set of tests to check coverage. That matrix
might need to be expanded for runtime PM interactions.

Cheers,
Ashok

On Thu, Feb 09, 2017 at 09:09:50AM -0600, Bjorn Helgaas wrote:
> [+cc Ashok, Keith]
> 
> > 
> > https://patchwork.kernel.org/patch/9557113/
> > https://patchwork.kernel.org/patch/9562007/
> 
> I don't think we've gotten to the root cause of the problem yet,
> and I don't want to throw in fixes at the last minute without a better
> understanding of it.
> 
> PCIe hotplug hardware is not very complicated, it hasn't changed in
> many years, and at least for the Intel hardware in question, is
> generally pretty well-tested with Windows.  So I want to be careful
> about asserting that this new piece of hardware is broken.
> 
> I think pciehp is unnecessarily complicated, and we do have known
> synchronization issues with it, e.g., [1] [2].  It seems possible that
> if we poked a little deeper, we would find that the hardware is
> actually working correctly and the real problem is in pciehp.
> 
> That's why I've been trying to have a conversation about how we
> interpret the spec and how we could remove PM and pciehp from the
> picture and experiment directly with setpci.
> 
> [1] https://lkml.kernel.org/r/1481317564-18045-1-git-send-email-ashok.raj@intel.com
> [2] https://bugzilla.kernel.org/show_bug.cgi?id=117561

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[GIT PULL] PCI fixes for v4.10 Bjorn Helgaas <helgaas@kernel.org> - 2017-02-08 20:50 +0100
  Re: [GIT PULL] PCI fixes for v4.10 Lukas Wunner <lukas@wunner.de> - 2017-02-09 05:40 +0100
    Re: [GIT PULL] PCI fixes for v4.10 Bjorn Helgaas <helgaas@kernel.org> - 2017-02-09 19:20 +0100
      Re: [GIT PULL] PCI fixes for v4.10 "Raj, Ashok" <ashok.raj@intel.com> - 2017-02-09 19:30 +0100
        Re: [GIT PULL] PCI fixes for v4.10 "Raj, Ashok" <ashok.raj@intel.com> - 2017-02-09 19:50 +0100
      Re: [GIT PULL] PCI fixes for v4.10 Bjorn Helgaas <helgaas@kernel.org> - 2017-02-09 21:20 +0100
        Re: [GIT PULL] PCI fixes for v4.10 "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-02-10 14:20 +0100
        Re: [GIT PULL] PCI fixes for v4.10 Yinghai Lu <yinghai@kernel.org> - 2017-02-11 03:50 +0100
          Re: [GIT PULL] PCI fixes for v4.10 Yinghai Lu <yinghai@kernel.org> - 2017-02-11 08:20 +0100
          Re: [GIT PULL] PCI fixes for v4.10 Lukas Wunner <lukas@wunner.de> - 2017-02-12 20:10 +0100
            Re: [GIT PULL] PCI fixes for v4.10 "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-02-13 13:20 +0100

csiph-web