Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1576477
| From | Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH -next] tpm_tis: fix the error handling of init_tis() |
| Date | 2017-02-08 12:40 +0100 |
| Message-ID | <t8yLn-8bT-9@gated-at.bofh.it> (permalink) |
| References | <t8glr-4NN-13@gated-at.bofh.it> |
| Organization | Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo |
On Tue, Feb 07, 2017 at 03:51:47PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Add the missing platform_driver_unregister() and remove the duplicate
> platform_device_unregister(force_pdev) in the error handling case.
>
> Fixes: 00194826e6be ("tpm_tis: Clean up the force=1 module parameter")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
> ---
> drivers/char/tpm/tpm_tis.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
> index 7912dad..c7e1384 100644
> --- a/drivers/char/tpm/tpm_tis.c
> +++ b/drivers/char/tpm/tpm_tis.c
> @@ -432,7 +432,7 @@ static int __init init_tis(void)
> acpi_bus_unregister_driver(&tis_acpi_driver);
> err_acpi:
> #endif
> - platform_device_unregister(force_pdev);
> + platform_driver_unregister(&tis_drv);
> err_platform:
> if (force_pdev)
> platform_device_unregister(force_pdev);
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH -next] tpm_tis: fix the error handling of init_tis() Wei Yongjun <weiyj.lk@gmail.com> - 2017-02-07 17:00 +0100
Re: [PATCH -next] tpm_tis: fix the error handling of init_tis() Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2017-02-07 18:10 +0100
Re: [PATCH -next] tpm_tis: fix the error handling of init_tis() Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-02-08 12:40 +0100
Re: [PATCH -next] tpm_tis: fix the error handling of init_tis() Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-02-08 12:50 +0100
csiph-web