[PATCH -next] tpm_tis: fix the error handling of init_tis()

From	Wei Yongjun <weiyj.lk@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH -next] tpm_tis: fix the error handling of init_tis()
Date	2017-02-07 17:00 +0100
Message-ID	<t8glr-4NN-13@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Wei Yongjun <weiyongjun1@huawei.com>

Add the missing platform_driver_unregister() and remove the duplicate
platform_device_unregister(force_pdev) in the error handling case.

Fixes: 00194826e6be ("tpm_tis: Clean up the force=1 module parameter")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/char/tpm/tpm_tis.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
index 7912dad..c7e1384 100644
--- a/drivers/char/tpm/tpm_tis.c
+++ b/drivers/char/tpm/tpm_tis.c
@@ -432,7 +432,7 @@ static int __init init_tis(void)
 	acpi_bus_unregister_driver(&tis_acpi_driver);
 err_acpi:
 #endif
-	platform_device_unregister(force_pdev);
+	platform_driver_unregister(&tis_drv);
 err_platform:
 	if (force_pdev)
 		platform_device_unregister(force_pdev);

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH -next] tpm_tis: fix the error handling of init_tis() Wei Yongjun <weiyj.lk@gmail.com> - 2017-02-07 17:00 +0100
  Re: [PATCH -next] tpm_tis: fix the error handling of init_tis() Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2017-02-07 18:10 +0100
  Re: [PATCH -next] tpm_tis: fix the error handling of init_tis() Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-02-08 12:40 +0100
    Re: [PATCH -next] tpm_tis: fix the error handling of init_tis() Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-02-08 12:50 +0100

csiph-web