Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1576117

[PATCH v2 net-next 5/9] sunvnet: add memory barrier before check for tx enable

Show all headers | View raw

In order to allow the underlying LDC and outstanding memory operations
to potentially catch up with the driver's Tx requests, add a memory
barrier before checking again for available tx descriptors.

Signed-off-by: Shannon Nelson <shannon.nelson@oracle.com>
---
 drivers/net/ethernet/sun/sunvnet_common.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/ethernet/sun/sunvnet_common.c b/drivers/net/ethernet/sun/sunvnet_common.c
index 82273e6..6cb625a 100644
--- a/drivers/net/ethernet/sun/sunvnet_common.c
+++ b/drivers/net/ethernet/sun/sunvnet_common.c
@@ -1453,6 +1453,7 @@ int sunvnet_start_xmit_common(struct sk_buff *skb, struct net_device *dev,
 	dr->prod = (dr->prod + 1) & (VNET_TX_RING_SIZE - 1);
 	if (unlikely(vnet_tx_dring_avail(dr) < 1)) {
 		netif_tx_stop_queue(txq);
+		smp_rmb();
 		if (vnet_tx_dring_avail(dr) > VNET_TX_WAKEUP_THRESH(dr))
 			netif_tx_wake_queue(txq);
 	}
-- 
1.7.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 net-next 0/9] sunvnet driver updates Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-07 23:20 +0100
  [PATCH v2 net-next 8/9] ldmvsw: update and simplify version string Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-07 23:20 +0100
  [PATCH v2 net-next 2/9] sunvnet: remove unused variable in maybe_tx_wakeup Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-07 23:20 +0100
  [PATCH v2 net-next 6/9] sunvnet: straighten up message event handling logic Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-07 23:20 +0100
    Re: [PATCH v2 net-next 6/9] sunvnet: straighten up message event  handling logic Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2017-02-08 17:10 +0100
      Re: [PATCH v2 net-next 6/9] sunvnet: straighten up message event  handling logic Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2017-02-08 17:40 +0100
      Re: [PATCH v2 net-next 6/9] sunvnet: straighten up message event  handling logic Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-08 17:40 +0100
  [PATCH v2 net-next 5/9] sunvnet: add memory barrier before check for tx enable Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-07 23:20 +0100
  [PATCH v2 net-next 1/9] sunvnet: make sunvnet common code dynamically loadable Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-07 23:20 +0100
    Re: [PATCH v2 net-next 1/9] sunvnet: make sunvnet common code  dynamically loadable David Miller <davem@davemloft.net> - 2017-02-08 20:40 +0100
      Re: [PATCH v2 net-next 1/9] sunvnet: make sunvnet common code  dynamically loadable Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-08 23:00 +0100
  [PATCH v2 net-next 4/9] sunvnet: add driver stats for ethtool support Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-07 23:20 +0100
  [PATCH v2 net-next 9/9] ldmvsw: disable tso and gso for bridge operations Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-07 23:20 +0100
  [PATCH v2 net-next 7/9] sunvnet: remove extra rcu_read_unlocks Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-07 23:30 +0100

csiph-web