Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1577133
| From | Shannon Nelson <shannon.nelson@oracle.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 net-next 1/9] sunvnet: make sunvnet common code dynamically loadable |
| Date | 2017-02-08 23:00 +0100 |
| Message-ID | <t8Iro-5Hm-33@gated-at.bofh.it> (permalink) |
| References | <t8mhb-fy-3@gated-at.bofh.it> <t8mhb-fy-17@gated-at.bofh.it> <t8GfU-4p7-9@gated-at.bofh.it> |
| Organization | Oracle Corporation |
On 2/8/2017 11:29 AM, David Miller wrote:
> From: Shannon Nelson <shannon.nelson@oracle.com>
> Date: Tue, 7 Feb 2017 14:12:54 -0800
>
>> +static int __init sunvnet_common_init(void)
>> +{
>> + pr_info("%s\n", version);
>> + return 0;
>> +}
>> +module_init(sunvnet_common_init);
>> +
>> +static void __exit sunvnet_common_exit(void)
>> +{
>> + /* Empty function, just here to fill the exit function pointer
>> + * slot. In some combinations of older gcc and newer kernel,
>> + * leaving this undefined results in the kernel marking it as a
>> + * permanent module; it will show up in lsmod output as [permanent]
>> + * and not be unloadable.
>> + */
>> +}
>> +module_exit(sunvnet_common_exit);
>> +
>
> This module is just providing infrastructure for other modules.
>
> So skip the init function, and that way you don't need the exit
> function either.
>
> The kernel log message when the real sunvnet driver loads is
> sufficient, you don't need one here.
>
Sure - thanks,
sln
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 net-next 0/9] sunvnet driver updates Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-07 23:20 +0100
[PATCH v2 net-next 8/9] ldmvsw: update and simplify version string Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-07 23:20 +0100
[PATCH v2 net-next 2/9] sunvnet: remove unused variable in maybe_tx_wakeup Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-07 23:20 +0100
[PATCH v2 net-next 6/9] sunvnet: straighten up message event handling logic Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-07 23:20 +0100
Re: [PATCH v2 net-next 6/9] sunvnet: straighten up message event handling logic Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2017-02-08 17:10 +0100
Re: [PATCH v2 net-next 6/9] sunvnet: straighten up message event handling logic Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2017-02-08 17:40 +0100
Re: [PATCH v2 net-next 6/9] sunvnet: straighten up message event handling logic Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-08 17:40 +0100
[PATCH v2 net-next 5/9] sunvnet: add memory barrier before check for tx enable Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-07 23:20 +0100
[PATCH v2 net-next 1/9] sunvnet: make sunvnet common code dynamically loadable Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-07 23:20 +0100
Re: [PATCH v2 net-next 1/9] sunvnet: make sunvnet common code dynamically loadable David Miller <davem@davemloft.net> - 2017-02-08 20:40 +0100
Re: [PATCH v2 net-next 1/9] sunvnet: make sunvnet common code dynamically loadable Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-08 23:00 +0100
[PATCH v2 net-next 4/9] sunvnet: add driver stats for ethtool support Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-07 23:20 +0100
[PATCH v2 net-next 9/9] ldmvsw: disable tso and gso for bridge operations Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-07 23:20 +0100
[PATCH v2 net-next 7/9] sunvnet: remove extra rcu_read_unlocks Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-07 23:30 +0100
csiph-web