Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1575730

Re: [PATCH v3 2/3] net: phy: dp83867: Add lane swapping support in the DP83867 TI's PHY driver

Show all headers | View raw

On Tue, Feb 07, 2017 at 06:20:23AM +0100, Lukasz Majewski wrote:
> This patch adds support for enabling or disabling the lane swapping (called
> "port mirroring" in PHY's CFG4 register) feature of the DP83867 TI's PHY
> device.
> 
> One use case is when bootstrap configuration enables this feature (because
> of e.g. LED_0 wrong wiring) so then one needs to disable it in software
> (at u-boot/Linux).
> 
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> ---
> Changes for v3:
> - Add "line swapping" to the patch description
> - Add DP83867_PORT_MIRROING_KEEP enum for better code readability
> 
> Changes for v2:
> - use "net-phy-lane-swap" and "net-phy-lane-no-swap" generic PHY properties.
>   instead of TI specific one
> ---
>  drivers/net/phy/dp83867.c | 38 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)

Hi Lukasz

You are missing the documentation update. Documentation/devicetree/binding/net/phy.h

Apart from that, this looks good.

Thanks
  Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 2/3] net: phy: dp83867: Add lane swapping support in the DP83867 TI's PHY driver Lukasz Majewski <lukma@denx.de> - 2017-02-07 06:30 +0100
  [PATCH v3 3/3] net: phy: dp83867: Recover from "port mirroring" N/A MODE4 Lukasz Majewski <lukma@denx.de> - 2017-02-07 06:30 +0100
    Re: [PATCH v3 3/3] net: phy: dp83867: Recover from "port mirroring"  N/A MODE4 Andrew Lunn <andrew@lunn.ch> - 2017-02-07 14:10 +0100
    Re: [PATCH v3 3/3] net: phy: dp83867: Recover from "port  mirroring" N/A MODE4 David Miller <davem@davemloft.net> - 2017-02-07 20:10 +0100
  Re: [PATCH v3 2/3] net: phy: dp83867: Add lane swapping support in  the DP83867 TI's PHY driver Andrew Lunn <andrew@lunn.ch> - 2017-02-07 14:10 +0100
  Re: [PATCH v3 2/3] net: phy: dp83867: Add lane swapping support in  the DP83867 TI's PHY driver Andrew Lunn <andrew@lunn.ch> - 2017-02-07 14:20 +0100
  Re: [PATCH v3 2/3] net: phy: dp83867: Add lane swapping support in  the DP83867 TI's PHY driver David Miller <davem@davemloft.net> - 2017-02-07 20:10 +0100

csiph-web