Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1577714

[PATCH -next] w1: ds2490: use kmemdup rather than duplicating its implementation

Path csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news2.arglkargh.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From Wei Yongjun <weiyj.lk@gmail.com>
Newsgroups linux.kernel
Subject [PATCH -next] w1: ds2490: use kmemdup rather than duplicating its implementation
Date Thu, 09 Feb 2017 16:50:01 +0100
Message-ID <t8Z8R-7WR-9@gated-at.bofh.it> (permalink)
X-Original-To Evgeniy Polyakov <zbr@ioremap.net>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4Os0fMSkbARxMrb+tOcjDIxU2RINlx7s7RZbDShn7N8=; b=IrfvKkOQIlcwJkGd5B5mIsAr4cDCjxOXF9kXiZzq16YQJA+7OQlUCVBLwzOnWhVih0 GIpUsnKGPCbbEhZRKIW+w4Iuhz/C4uEw6WMeFjMY6zrl/hqIPv7uacQZMfZVZhEY+1nA QWR4EjC0LurvShdyicxssVWHP980Ktprk0yDEQdP2cfB9KoFRW6kSvQfxa+HaKduHeas 5HW8jRwhrH9JKsZASnTUhUK4I5QV7qpZspn+YIEBe3s8/08TIX2VdFp+oz4yEk52KCeV i9bo1LX9WgVHLH3EkyRtUZVcFSUdR+kiAKoUHGS6cfnWFphH0jCk4KCPygsxM2n6sHyl yrGg==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4Os0fMSkbARxMrb+tOcjDIxU2RINlx7s7RZbDShn7N8=; b=AntWKHNIk8jhAHrYg63ULIZtWXh3uCL5fgQv84cXj5l1zR2uqv4ReDThg0Mv7MC//l tp6RNycCDmO4nYdO1W6nruUdMZmgCNgFhEXbT8eqSzWYJlEvcH2UovC0ICMfZ9OfJI1w 9zt68jqb/TW2AvNGgNgnZfgmeyq8vD1DHoRmUC6G5GphaozVIkqsKdH5qRGsu5rOH4ev s9eEbPTpAYjptzXET1pCG9V4u7Wy0j7KYYiEETPce+ZFQvA6PA9XuZuFZJbfTbcffcqy 1Y8vpFKGy/NoHQBzgCAfnH+DWy+O3QgSEDmfY+YrzUjGYjiBI/W1UvtlHac6ckCfgyhX 00CQ==
X-Gm-Message-State AMke39lbNmI2mex7BKsgVvb9zXvhgq1NUtHngwx67cgPjABvSlK/SeMTT0YIAgJyQWUCGg==
X-Received by 10.98.206.6 with SMTP id y6mr4396789pfg.122.1486655150466; Thu, 09 Feb 2017 07:45:50 -0800 (PST)
X-Mailer git-send-email 2.9.3
MIME-Version 1.0
Content-Type text/plain; charset=ISO-8859-1
Content-Transfer-Encoding 7bit
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 28
Organization linux.* mail to news gateway
X-Original-Cc Wei Yongjun <weiyongjun1@huawei.com>, linux-kernel@vger.kernel.org
X-Original-Date Thu, 9 Feb 2017 15:45:42 +0000
X-Original-Message-ID <20170209154542.16315-1-weiyj.lk@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1577714

Show key headers only | View raw


From: Wei Yongjun <weiyongjun1@huawei.com>

Use kmemdup rather than duplicating its implementation.

Generated by: scripts/coccinelle/api/memdup.cocci

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/w1/masters/ds2490.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/w1/masters/ds2490.c b/drivers/w1/masters/ds2490.c
index 59d74d1..be77b79 100644
--- a/drivers/w1/masters/ds2490.c
+++ b/drivers/w1/masters/ds2490.c
@@ -909,11 +909,10 @@ static void ds9490r_write_block(void *data, const u8 *buf, int len)
 	if (len <= 0)
 		return;
 
-	tbuf = kmalloc(len, GFP_KERNEL);
+	tbuf = kmemdup(buf, len, GFP_KERNEL);
 	if (!tbuf)
 		return;
 
-	memcpy(tbuf, buf, len);
 	ds_write_block(dev, tbuf, len);
 
 	kfree(tbuf);

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

[PATCH -next] w1: ds2490: use kmemdup rather than duplicating its implementation Wei Yongjun <weiyj.lk@gmail.com> - 2017-02-09 16:50 +0100
  Re: [PATCH -next] w1: ds2490: use kmemdup rather than duplicating its  implementation "Maciej S. Szmigiero" <mail@maciej.szmigiero.name> - 2017-02-10 02:50 +0100

csiph-web