[PATCH -next] w1: ds2490: use kmemdup rather than duplicating its implementation

From	Wei Yongjun <weiyj.lk@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH -next] w1: ds2490: use kmemdup rather than duplicating its implementation
Date	2017-02-09 16:50 +0100
Message-ID	<t8Z8R-7WR-9@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Wei Yongjun <weiyongjun1@huawei.com>

Use kmemdup rather than duplicating its implementation.

Generated by: scripts/coccinelle/api/memdup.cocci

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/w1/masters/ds2490.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/w1/masters/ds2490.c b/drivers/w1/masters/ds2490.c
index 59d74d1..be77b79 100644
--- a/drivers/w1/masters/ds2490.c
+++ b/drivers/w1/masters/ds2490.c
@@ -909,11 +909,10 @@ static void ds9490r_write_block(void *data, const u8 *buf, int len)
 	if (len <= 0)
 		return;
 
-	tbuf = kmalloc(len, GFP_KERNEL);
+	tbuf = kmemdup(buf, len, GFP_KERNEL);
 	if (!tbuf)
 		return;
 
-	memcpy(tbuf, buf, len);
 	ds_write_block(dev, tbuf, len);
 
 	kfree(tbuf);

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH -next] w1: ds2490: use kmemdup rather than duplicating its implementation Wei Yongjun <weiyj.lk@gmail.com> - 2017-02-09 16:50 +0100
  Re: [PATCH -next] w1: ds2490: use kmemdup rather than duplicating its  implementation "Maciej S. Szmigiero" <mail@maciej.szmigiero.name> - 2017-02-10 02:50 +0100

csiph-web