Re: [PATCH] omapfb: dss: Handle return error in dss_init_ports.

From	Arvind Yadav <arvind.yadav.cs@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] omapfb: dss: Handle return error in dss_init_ports.
Date	2017-02-09 11:10 +0100
Message-ID	<t8TPQ-4PF-3@gated-at.bofh.it> (permalink)
References	<t7ToS-6Gk-17@gated-at.bofh.it> <t8cUx-2IN-5@gated-at.bofh.it> <t8xPj-7AX-7@gated-at.bofh.it> <t8BzA-1u7-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,
Yes, We will have to handle cleanup of partially initialized ports.
As per your suggestion, I have done the changes.

Thanks
-Arvind

On Wednesday 08 February 2017 07:51 PM, Bartlomiej Zolnierkiewicz wrote:
> On Wednesday, February 08, 2017 11:25:47 AM Bartlomiej Zolnierkiewicz wrote:
>> Hi,
>>
>> On Tuesday, February 07, 2017 05:41:37 PM Arvind Yadav wrote:
>>> Hi,
>>>
>>> In dss_init_ports, There is no need to add dss_uninit_ports before
>>> returning.
>>> Because it's already take care in dss_bind. dss_bind  is handling
>>> dss_uninit_ports in error path.
>> It doesn't handle cleanup of partially initialized ports,
> BTW by "partially initialized ports" here I mean cases like
> i.e. dpi port fully initialized and sdi one not initialized
>
>> please look at the code:
>>
>> ...
>> 	r = dss_init_ports(pdev);
>> 	if (r)
>> 		goto err_init_ports;
>> ...
>> err_runtime_get:
>> 	pm_runtime_disable(&pdev->dev);
>> 	dss_uninit_ports(pdev);
>> err_init_ports:
>> 	if (dss.video1_pll)
>> 		dss_video_pll_uninit(dss.video1_pll);
>> ...
>>
>> dss_uninit_ports() is not called on partially initialized
> ditto
>
>> ports (when dss_init_ports() returns an error we go straight
>> into err_init_ports label and skip dss_uninit_ports())
>>
>>> -Arvind
>>>
>>>
>>> On Monday 06 February 2017 08:58 PM, Bartlomiej Zolnierkiewicz wrote:
>>>> dpi_uninit_port() & sdi_uninit_port() skip not fully
>>>> initialized port
> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] omapfb: dss: Handle return error in dss_init_ports. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-02-03 13:30 +0100
  Re: [PATCH] omapfb: dss: Handle return error in dss_init_ports. Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-02-06 16:30 +0100
    Re: [PATCH] omapfb: dss: Handle return error in dss_init_ports. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-02-07 13:20 +0100
      Re: [PATCH] omapfb: dss: Handle return error in dss_init_ports. Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-02-08 11:40 +0100
        Re: [PATCH] omapfb: dss: Handle return error in dss_init_ports. Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-02-08 15:40 +0100
          Re: [PATCH] omapfb: dss: Handle return error in dss_init_ports. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-02-09 11:10 +0100

csiph-web