Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1577359

Re: [PATCH -next] rtc: sun6i: Fix return value check in sun6i_rtc_clk_init()

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Feb 09, 2017 at 12:16:13AM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> In case of error, the function of_io_request_and_map() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check should
> be replaced with IS_ERR().
> 
> Fixes: 847b8bf62eb4 ("rtc: sun6i: Expose the 32kHz oscillator")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH -next] rtc: sun6i: Fix return value check in sun6i_rtc_clk_init() Wei Yongjun <weiyj.lk@gmail.com> - 2017-02-09 01:50 +0100
  Re: [PATCH -next] rtc: sun6i: Fix return value check in  sun6i_rtc_clk_init() Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-02-09 08:50 +0100
  Re: [PATCH -next] rtc: sun6i: Fix return value check in  sun6i_rtc_clk_init() Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-02-12 00:40 +0100

csiph-web