[PATCH v2] Input: xpad - restore LED state after device resume

Path	csiph.com!news.freedyn.net!open-news-network.org!aioe.org!bofh.it!news.nic.it!robomod
From	Cameron Gutman <aicommander@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH v2] Input: xpad - restore LED state after device resume
Date	Tue, 07 Feb 2017 02:00:01 +0100
Message-ID	<t82it-3XP-15@gated-at.bofh.it> (permalink)
X-Original-To	dmitry.torokhov@gmail.com, rojtberg@gmail.com
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=6IjYF+coVjZ3cx9/J1SFyCRLllw8Ta9q4HVWbzrHtfg=; b=Qki5yVlAXd3kfkXvmirztpIZmUC3rB2aBqMSi6vb6FjLJYTrTULwSWEglN3RjR8avm mwyQu4PahnfSWXf07orgAveTGgzXoo2p84lkhrWu/skaLgrpzr7HQB2HLTsZy2YQz/oQ CruT8j/Ct3Qpw8ayei+DfKBpxSXRrvqxgn85P9w+T55VLIoQBDlQbhdU0B0IYo8fnqm7 gfYGm+OfaXCKQbc9tCtl/DY84lXntAOiL+9IHVodtJK5aUKvMF1L1lVfMGsWBPGln4na W/t0HplN+a0BQ8JncGg7V9S240ZCorwcXjee2chY84Sn3BZRcgNRFAd7vHa5kHZ3ANo6 dL1g==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=6IjYF+coVjZ3cx9/J1SFyCRLllw8Ta9q4HVWbzrHtfg=; b=CZdm+P8xBlp/fF0gxjRJYOTJFtBmRrFvFx4LuMTS8LsZbppWJgWw2qqvCyvYKgc/Zf VLsmwDOSXBaKA/bjTOmjBkCB9wCzf6EVAwp8hXhBKKkRNXuZ5nEo1KdjgeCvhsd6/4cW x97bheo/8Y6OPG5ILfQh0ubjI2/6P7PB40Lkdx7lXlbMqCr14gdggLofbXNjJmz6BSgY gh95IqZ1LAKyRnPdFuIyEEp6Btc1vTgxW/225+BjBVE97EL+sbB0Yg5zRxr4rUT4Dz9B 0kW8/720eEnwKcye+IFsjFXoWIB5gSjBFBLMnmnL9YpfhYbyYJY1Ak1Mg6GJ2G/WCu+z IgEA==
X-Gm-Message-State	AIkVDXI6qdViTDs43BJZGzABF53dpMacRHiuAJcrBcAy6VfUrfBW2vRlh4LEX+ee5FVI2Q==
X-Received	by 10.99.155.18 with SMTP id r18mr16468654pgd.193.1486429141205; Mon, 06 Feb 2017 16:59:01 -0800 (PST)
X-Mailer	git-send-email 2.9.3
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	50
Organization	linux.* mail to news gateway
X-Original-Cc	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Cameron Gutman <aicommander@gmail.com>
X-Original-Date	Mon, 6 Feb 2017 16:58:38 -0800
X-Original-Message-ID	<20170207005838.20095-1-aicommander@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1575295

Show key headers only | View raw

Set the LED_CORE_SUSPENDRESUME flag on our LED device so the
LED state will be automatically restored by LED core on resume.

Since Xbox One pads stop flashing only when reinitialized, we'll
send them the initialization packet so they calm down too.

Signed-off-by: Cameron Gutman <aicommander@gmail.com>
---
Sending this one alone, since the rest of the series was applied or
needs non-trivial reworking.

Thanks,
Cameron

---
 drivers/input/joystick/xpad.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index 13975aa..18697f1 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -1240,6 +1240,7 @@ static int xpad_led_probe(struct usb_xpad *xpad)
 	led_cdev = &led->led_cdev;
 	led_cdev->name = led->name;
 	led_cdev->brightness_set = xpad_led_set;
+	led_cdev->flags = LED_CORE_SUSPENDRESUME;
 
 	error = led_classdev_register(&xpad->udev->dev, led_cdev);
 	if (error)
@@ -1716,8 +1717,16 @@ static int xpad_resume(struct usb_interface *intf)
 		retval = xpad360w_start_input(xpad);
 	} else {
 		mutex_lock(&input->mutex);
-		if (input->users)
+		if (input->users) {
 			retval = xpad_start_input(xpad);
+		} else if (xpad->xtype == XTYPE_XBOXONE) {
+			/*
+			 * Even if there are no users, we'll send Xbox One pads
+			 * the startup sequence so they don't sit there and
+			 * blink until somebody opens the input device again.
+			 */
+			retval = xpad_start_xbox_one(xpad);
+		}
 		mutex_unlock(&input->mutex);
 	}
 
-- 
2.9.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] Input: xpad - restore LED state after device resume Cameron Gutman <aicommander@gmail.com> - 2017-02-07 02:00 +0100
  Re: [PATCH v2] Input: xpad - restore LED state after device resume Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-02-07 02:10 +0100

csiph-web