Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1573947

Re: [PATCH 1/2] sigaltstack: support SS_AUTODISARM for CONFIG_COMPAT

Show all headers | View raw

On Sun, Feb 5, 2017 at 2:12 AM, Stas Sergeev <stsp@list.ru> wrote:
> Currently SS_AUTODISARM is not supported in compatibility
> mode, but does not return -EINVAL either. This makes dosemu
> built with -m32 on x86_64 to crash. Also the kernel's sigaltstack
> selftest fails if compiled with -m32.
>
> This patch adds the needed support.
>
> Suggesting for -stable.

This looks correct.  I find it odd that we used to check the old sp to
figure out whether to put SA_ONSTACK into the signal frame, but I do
think the new behavior is better.  In any event, this changes the
compat case to work like the native case, and no one noticed when the
native behavior changed, so it's fine by me.

--Andy

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/2] sigaltstack: SS_AUTODISARM fixes Stas Sergeev <stsp@list.ru> - 2017-02-05 12:20 +0100
  Re: [PATCH 1/2] sigaltstack: support SS_AUTODISARM for CONFIG_COMPAT Andy Lutomirski <luto@amacapital.net> - 2017-02-05 19:40 +0100
    Re: [PATCH 1/2] sigaltstack: support SS_AUTODISARM for CONFIG_COMPAT Stas Sergeev <stsp@list.ru> - 2017-02-06 10:40 +0100
      Re: [PATCH 1/2] sigaltstack: support SS_AUTODISARM for  CONFIG_COMPAT Andrew Morton <akpm@linux-foundation.org> - 2017-02-07 01:10 +0100
        [PATCH 2/2] tests: improve output of sigaltstack testcase Stas Sergeev <stsp@list.ru> - 2017-02-07 10:20 +0100

csiph-web