Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1573722

Re: [PATCH net-next 6/6] net: dsa: introduce bridge notifier

From Andrew Lunn <andrew@lunn.ch>
Newsgroups linux.kernel
Subject Re: [PATCH net-next 6/6] net: dsa: introduce bridge notifier
Date 2017-02-04 19:00 +0100
Message-ID <t7cMW-3Wb-9@gated-at.bofh.it> (permalink)
References <t6QMp-5eA-1@gated-at.bofh.it> <t6QMq-5eA-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


> +#define DSA_NOTIFIER_BRIDGE_JOIN		1
> +#define DSA_NOTIFIER_BRIDGE_LEAVE		2

Hi Vivien

Is one notifier per event sufficient?

I've not looked at what actually needs to happen when a port joins a
bridge, in a D in DSA setup. Do we need to both enable the flow of
frames around the switch fabric, but also block those frames going out
ports they should not? Do we need a first notifier to put in place
the blocks, and then a second notifier to enable the flow of packets?

What we don't want is a window of time during the fabric setup as a
whole is inconsistent, and frames a leaking out ports they should not.

      Andrew

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH net-next 0/6] net: dsa: add fabric notifier Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-02-03 19:30 +0100
  [PATCH net-next 4/6] net: dsa: change state setter scope Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-02-03 19:30 +0100
  [PATCH net-next 3/6] net: dsa: rollback bridging on error Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-02-03 19:30 +0100
  [PATCH net-next 6/6] net: dsa: introduce bridge notifier Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-02-03 19:30 +0100
    Re: [PATCH net-next 6/6] net: dsa: introduce bridge notifier Andrew Lunn <andrew@lunn.ch> - 2017-02-04 19:00 +0100
      Re: [PATCH net-next 6/6] net: dsa: introduce bridge notifier Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-02-04 19:30 +0100
        Re: [PATCH net-next 6/6] net: dsa: introduce bridge notifier Andrew Lunn <andrew@lunn.ch> - 2017-02-04 19:40 +0100
  [PATCH net-next 5/6] net: dsa: add switch notifier Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-02-03 19:30 +0100
  [PATCH net-next 1/6] net: dsa: move netdevice notifier registration Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-02-03 19:30 +0100
  [PATCH net-next 2/6] net: dsa: simplify netdevice events handling Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-02-03 19:30 +0100
    Re: [PATCH net-next 2/6] net: dsa: simplify netdevice events handling Florian Fainelli <f.fainelli@gmail.com> - 2017-02-04 03:50 +0100
      Re: [PATCH net-next 2/6] net: dsa: simplify netdevice events handling Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-02-04 17:20 +0100
  Re: [PATCH net-next 0/6] net: dsa: add fabric notifier David Miller <davem@davemloft.net> - 2017-02-06 23:00 +0100

csiph-web