Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1575032

Re: [PATCH 3/5] drm: convert drivers to use of_graph_get_remote_node

Show all headers | View raw

On Mon, Feb 6, 2017 at 11:23 AM, Liviu Dudau <liviu.dudau@arm.com> wrote:
> On Mon, Feb 06, 2017 at 11:09:49AM -0600, Rob Herring wrote:
>> On Mon, Feb 06, 2017 at 10:29:33AM +0000, Liviu Dudau wrote:
>> > On Fri, Feb 03, 2017 at 09:36:33PM -0600, Rob Herring wrote:
>> > > Convert drivers to use the new of_graph_get_remote_node() helper
>> > > instead of parsing the endpoint node and then getting the remote device
>> > > node. Now drivers can just specify the device node and which
>> > > port/endpoint and get back the connected remote device node. The details
>> > > of the graph binding are nicely abstracted into the core OF graph code.
>> > >
>> > > This changes some error messages to debug messages (in the graph core).
>> > > Graph connections are often "no connects" depending on the particular
>> > > board, so we want to avoid spurious messages. Plus the kernel is not a
>> > > DT validator.

[...]

>> > > - /* add the remote encoder port as component */
>> > > - port = of_graph_get_remote_port_parent(ep);
>> > > - of_node_put(ep);
>> > > - if (!port || !of_device_is_available(port)) {
>> > > -         of_node_put(port);
>> > > -         return -EAGAIN;
>> >
>> > The HDLCD change looks reasonable except for this -EAGAIN business. I'll have to
>> > test your changes on my setup to see how this affects having the encoder as a module.
>>
>> What are you expecting to happen with -EAGAIN? This one was a bit of an
>> oddball.
>
> When both the HDLCD and the TDA998x drivers are compiled as modules, the order in which
> they are inserted can be somewhat random (due to testing). It is at that time when you
> want the probe of HDLCD to be retried on the insmod-ing of the tda998x.ko rather than
> fail entirely.
>
>>
>> This condition would only change if you had an overlay. That's a use
>> case that needs to be handled in a common way ('cause I don't want to
>> clean-up every driver doing overlays in their own way latter). Just
>> having "status" changing at runtime would have all sorts of implications
>> in the kernel.
>
> Hmm, not sure what you mean here with overlays. Are you thinking that the
> remote port is initially disabled and then re-enabled by an overlay? That is
> not the only way of_device_is_available() can fail, see above regarding modules.

Russell pretty much answered most of this, but specifically for
of_device_is_available, the only way of_device_is_available() can
change is a DT change with "status" changing. The only way
of_graph_get_remote_port_parent changes is also from a DT change.

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/5] drm: convert drivers to use of_graph_get_remote_node Rob Herring <robh@kernel.org> - 2017-02-04 04:40 +0100
  Re: [PATCH 3/5] drm: convert drivers to use of_graph_get_remote_node Jyri Sarha <jsarha@ti.com> - 2017-02-06 09:40 +0100
  Re: [PATCH 3/5] drm: convert drivers to use of_graph_get_remote_node Neil Armstrong <narmstrong@baylibre.com> - 2017-02-06 11:20 +0100
  Re: [PATCH 3/5] drm: convert drivers to use of_graph_get_remote_node Liviu Dudau <liviu.dudau@arm.com> - 2017-02-06 11:30 +0100
    Re: [PATCH 3/5] drm: convert drivers to use of_graph_get_remote_node Rob Herring <robh@kernel.org> - 2017-02-06 18:10 +0100
      Re: [PATCH 3/5] drm: convert drivers to use of_graph_get_remote_node Liviu Dudau <liviu.dudau@arm.com> - 2017-02-06 18:30 +0100
        Re: [PATCH 3/5] drm: convert drivers to use of_graph_get_remote_node Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-02-06 18:40 +0100
          Re: [PATCH 3/5] drm: convert drivers to use of_graph_get_remote_node Liviu Dudau <liviu.dudau@arm.com> - 2017-02-06 19:00 +0100
            Re: [PATCH 3/5] drm: convert drivers to use of_graph_get_remote_node Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-02-06 19:10 +0100
        Re: [PATCH 3/5] drm: convert drivers to use of_graph_get_remote_node Rob Herring <robh@kernel.org> - 2017-02-06 18:50 +0100
  Re: [PATCH 3/5] drm: convert drivers to use of_graph_get_remote_node Philipp Zabel <p.zabel@pengutronix.de> - 2017-02-06 12:00 +0100
    Re: [PATCH 3/5] drm: convert drivers to use of_graph_get_remote_node Rob Herring <robh@kernel.org> - 2017-02-06 14:50 +0100
  Re: [PATCH 3/5] drm: convert drivers to use of_graph_get_remote_node Liviu Dudau <liviu.dudau@arm.com> - 2017-02-08 14:00 +0100
  Re: [PATCH 3/5] drm: convert drivers to use of_graph_get_remote_node Eric Anholt <eric@anholt.net> - 2017-02-08 21:50 +0100

csiph-web