Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1574579

Re: [PATCH] drm/vc4: simplify exit path of a failed allocation of dsi_connector

Show all headers | View raw

Hi Colin,

2017-02-03 Colin King <colin.king@canonical.com>:

> From: Colin Ian King <colin.king@canonical.com>
> 
> If dsi_connector fails to allocate, the exit path via label 'fail'
> checks if connector is null, which it always is, so the cleanup
> that destroys connector is never going to be called.  Hence the
> failure path can be more optimally performed by removing this
> and just returning ERR_PTR(-ENOMEM).  This also removes the need
> to initialize connector to NULL, and we can also remove ret too.
> 
> Detected by CoverityScan, CID#1399504 ("Logicall Dead Code")
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/gpu/drm/vc4/vc4_dsi.c | 16 ++++------------
>  1 file changed, 4 insertions(+), 12 deletions(-)

Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com>

Gustavo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] drm/vc4: simplify exit path of a failed allocation of dsi_connector Colin King <colin.king@canonical.com> - 2017-02-03 21:00 +0100
  Re: [PATCH] drm/vc4: simplify exit path of a failed allocation of  dsi_connector Gustavo Padovan <gustavo@padovan.org> - 2017-02-06 12:50 +0100
  Re: [PATCH] drm/vc4: simplify exit path of a failed allocation of dsi_connector Eric Anholt <eric@anholt.net> - 2017-02-08 00:50 +0100

csiph-web