Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1574580

Re: [PATCH -next] drm: mxsfb: fix error return code in mxsfb_load()

Show all headers | View raw

Hi Wei,

2017-02-05 Wei Yongjun <weiyj.lk@gmail.com>:

> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  drivers/gpu/drm/mxsfb/mxsfb_drv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> index cdfbe02..28a75cb 100644
> --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> @@ -221,6 +221,7 @@ static int mxsfb_load(struct drm_device *drm, unsigned long flags)
>  	mxsfb->fbdev = drm_fbdev_cma_init(drm, 32,
>  					  drm->mode_config.num_connector);
>  	if (IS_ERR(mxsfb->fbdev)) {
> +		ret = PTR_ERR(mxsfb->fbdev);
>  		mxsfb->fbdev = NULL;
>  		dev_err(drm->dev, "Failed to init FB CMA area\n");
>  		goto err_cma;

Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com>

Gustavo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH -next] drm: mxsfb: fix error return code in mxsfb_load() Wei Yongjun <weiyj.lk@gmail.com> - 2017-02-05 17:10 +0100
  Re: [PATCH -next] drm: mxsfb: fix error return code in mxsfb_load() Gustavo Padovan <gustavo@padovan.org> - 2017-02-06 12:50 +0100
  Re: [PATCH -next] drm: mxsfb: fix error return code in mxsfb_load() Marek Vasut <marex@denx.de> - 2017-02-06 21:20 +0100

csiph-web