Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1572494
| From | Petr Mladek <pmladek@suse.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCHv7 5/8] printk: report lost messages in printk safe/nmi contexts |
| Date | 2017-02-02 17:20 +0100 |
| Message-ID | <t6sh3-6ho-9@gated-at.bofh.it> (permalink) |
| References | <sT0LE-36Q-9@gated-at.bofh.it> <sT0LE-36Q-7@gated-at.bofh.it> <t666R-8hp-1@gated-at.bofh.it> <t6f0u-5UQ-3@gated-at.bofh.it> <t6qIh-5eS-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu 2017-02-02 09:34:09, Steven Rostedt wrote:
> On Thu, 2 Feb 2017 11:02:57 +0900
> Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> wrote:
>
> > On (02/01/17 11:37), Steven Rostedt wrote:
> > > This looks fine, but I'm curious if you tested it. That is, added a
> > > bunch of printks to overflow the buffer. IIRC, I did it to the original
> > > nmi code. If you haven't you may want to just to make sure it works. I
> > > can also test it too if I get some time.
I have tested it and actually found a bug. I was lucky because it was
a cornercase. It is already fixed upstream by the commit
4a998e322abc935e ("printk/NMI: fix up handling of the full nmi
log buffer").
> Please note how you tested it in your change log. It's not really a
> requirement, and you don't really have to do it. But it helps people
> have warm fuzzies about the code. I'm trying to do this in the future
> in my own work too.
Goot to know.
Best Regards,
Petr
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCHv7 5/8] printk: report lost messages in printk safe/nmi contexts Steven Rostedt <rostedt@goodmis.org> - 2017-02-01 17:40 +0100
Re: [PATCHv7 5/8] printk: report lost messages in printk safe/nmi contexts Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-02-02 03:10 +0100
Re: [PATCHv7 5/8] printk: report lost messages in printk safe/nmi contexts Steven Rostedt <rostedt@goodmis.org> - 2017-02-02 15:40 +0100
Re: [PATCHv7 5/8] printk: report lost messages in printk safe/nmi contexts Petr Mladek <pmladek@suse.com> - 2017-02-02 17:20 +0100
Re: [PATCHv7 5/8] printk: report lost messages in printk safe/nmi contexts Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-02-03 03:00 +0100
Re: [PATCHv7 5/8] printk: report lost messages in printk safe/nmi contexts Steven Rostedt <rostedt@goodmis.org> - 2017-02-03 04:20 +0100
csiph-web