Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1571712

Re: [PATCHv7 5/8] printk: report lost messages in printk safe/nmi contexts

Show all headers | View raw

On Tue, 27 Dec 2016 23:16:08 +0900
Sergey Senozhatsky <sergey.senozhatsky@gmail.com> wrote:

> Account lost messages in pritk-safe and printk-safe-nmi
> contexts and report those numbers during printk_safe_flush().
> 
> The patch also moves lost message counter to struct
> `printk_safe_seq_buf' instead of having dedicated static
> counters - this simplifies the code.
> 
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> ---

This looks fine, but I'm curious if you tested it. That is, added a
bunch of printks to overflow the buffer. IIRC, I did it to the original
nmi code. If you haven't you may want to just to make sure it works. I
can also test it too if I get some time.

-- Steve

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCHv7 5/8] printk: report lost messages in printk safe/nmi  contexts Steven Rostedt <rostedt@goodmis.org> - 2017-02-01 17:40 +0100
  Re: [PATCHv7 5/8] printk: report lost messages in printk safe/nmi  contexts Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-02-02 03:10 +0100
    Re: [PATCHv7 5/8] printk: report lost messages in printk safe/nmi  contexts Steven Rostedt <rostedt@goodmis.org> - 2017-02-02 15:40 +0100
      Re: [PATCHv7 5/8] printk: report lost messages in printk safe/nmi  contexts Petr Mladek <pmladek@suse.com> - 2017-02-02 17:20 +0100
      Re: [PATCHv7 5/8] printk: report lost messages in printk safe/nmi  contexts Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-02-03 03:00 +0100
        Re: [PATCHv7 5/8] printk: report lost messages in printk safe/nmi  contexts Steven Rostedt <rostedt@goodmis.org> - 2017-02-03 04:20 +0100

csiph-web