Re: [PATCH 2/9] virtio_pci: use shared interrupts for virtqueues

From	Jason Wang <jasowang@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/9] virtio_pci: use shared interrupts for virtqueues
Date	2017-02-03 11:00 +0100
Message-ID	<t6IOT-8nh-61@gated-at.bofh.it> (permalink)
References	(1 earlier) <t4a4V-1M6-3@gated-at.bofh.it> <t6GWL-7cT-19@gated-at.bofh.it> <t6HpM-7CB-7@gated-at.bofh.it> <t6IFc-8jr-9@gated-at.bofh.it> <t6IOT-8nh-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 2017年02月03日 17:52, Christoph Hellwig wrote:
> On Fri, Feb 03, 2017 at 05:47:41PM +0800, Jason Wang wrote:
>>> No, we need to allocate the array larger in that case as want proper
>>> names for the interrupts.
>> Consider the case of !per_vq_vectors, the size of msix_names is 2, but
>> snprintf can do out of bound accessing here. (We name the msix shared by
>> virtqueues with something like "%s-virtqueues" before the patch).
> Yes, that's what I meant above - we need to allocate a large array
> starting with this patch.  I'll fix it up for the next version.

I see.

Thanks

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/9] virtio_pci: use shared interrupts for virtqueues Jason Wang <jasowang@redhat.com> - 2017-02-03 09:00 +0100
  Re: [PATCH 2/9] virtio_pci: use shared interrupts for virtqueues Christoph Hellwig <hch@lst.de> - 2017-02-03 09:30 +0100
    Re: [PATCH 2/9] virtio_pci: use shared interrupts for virtqueues Jason Wang <jasowang@redhat.com> - 2017-02-03 10:50 +0100
      Re: [PATCH 2/9] virtio_pci: use shared interrupts for virtqueues Christoph Hellwig <hch@lst.de> - 2017-02-03 11:00 +0100
        Re: [PATCH 2/9] virtio_pci: use shared interrupts for virtqueues Jason Wang <jasowang@redhat.com> - 2017-02-03 11:00 +0100

csiph-web