Re: [PATCH 2/9] virtio_pci: use shared interrupts for virtqueues

From	Jason Wang <jasowang@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/9] virtio_pci: use shared interrupts for virtqueues
Date	2017-02-03 09:00 +0100
Message-ID	<t6GWL-7cT-19@gated-at.bofh.it> (permalink)
References	<t49Vg-1J9-5@gated-at.bofh.it> <t4a4V-1M6-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 2017年01月27日 16:16, Christoph Hellwig wrote:
> +		snprintf(vp_dev->msix_names[i + 1],
> +			 sizeof(*vp_dev->msix_names), "%s-%s",
>   			 dev_name(&vp_dev->vdev.dev), names[i]);
>   		err = request_irq(pci_irq_vector(vp_dev->pci_dev, msix_vec),
> -				  vring_interrupt, 0,
> -				  vp_dev->msix_names[msix_vec],
> -				  vqs[i]);
> +				  vring_interrupt, IRQF_SHARED,
> +				  vp_dev->msix_names[i + 1], vqs[i]);

Do we need to check per_vq_vectors before dereferencing msix_names[i + 1] ?

Thanks

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/9] virtio_pci: use shared interrupts for virtqueues Jason Wang <jasowang@redhat.com> - 2017-02-03 09:00 +0100
  Re: [PATCH 2/9] virtio_pci: use shared interrupts for virtqueues Christoph Hellwig <hch@lst.de> - 2017-02-03 09:30 +0100
    Re: [PATCH 2/9] virtio_pci: use shared interrupts for virtqueues Jason Wang <jasowang@redhat.com> - 2017-02-03 10:50 +0100
      Re: [PATCH 2/9] virtio_pci: use shared interrupts for virtqueues Christoph Hellwig <hch@lst.de> - 2017-02-03 11:00 +0100
        Re: [PATCH 2/9] virtio_pci: use shared interrupts for virtqueues Jason Wang <jasowang@redhat.com> - 2017-02-03 11:00 +0100

csiph-web