Re: [PATCH] Misc: eeprom - Fix possible NULL derefrence.

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Misc: eeprom - Fix possible NULL derefrence.
Date	2017-01-30 20:40 +0100
Message-ID	<t5pXY-7V1-19@gated-at.bofh.it> (permalink)
References	<t4d2P-3w5-37@gated-at.bofh.it> <t4d2P-3w5-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jan 27, 2017 at 04:42:31PM +0530, Shailendra Verma wrote:
> of_match_device could return NULL, and so can cause a NULL
> pointer dereference later.
> 
> Signed-off-by: Shailendra Verma <shailendra.v@samsung.com>
> ---
>  drivers/misc/eeprom/eeprom_93xx46.c |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/misc/eeprom/eeprom_93xx46.c b/drivers/misc/eeprom/eeprom_93xx46.c
> index 94cc035..6555975 100644
> --- a/drivers/misc/eeprom/eeprom_93xx46.c
> +++ b/drivers/misc/eeprom/eeprom_93xx46.c
> @@ -381,6 +381,11 @@ static int eeprom_93xx46_probe_dt(struct spi_device *spi)
>  	enum of_gpio_flags of_flags;
>  	int ret;
>  
> +	if (!of_id) {
> +		dev_err(&spi->dev, "Error: No device match found\n");
> +		return -ENODEV;
> +	}
> +

Also dropped due to this not being possible.

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Misc: eeprom - Fix possible NULL derefrence. Shailendra Verma <shailendra.v@samsung.com> - 2017-01-27 12:40 +0100
  Re: [PATCH] Misc: eeprom - Fix possible NULL derefrence. Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-01-30 20:40 +0100

csiph-web