[PATCH] Misc: eeprom - Fix possible NULL derefrence.

From	Shailendra Verma <shailendra.v@samsung.com>
Newsgroups	linux.kernel
Subject	[PATCH] Misc: eeprom - Fix possible NULL derefrence.
Date	2017-01-27 12:40 +0100
Message-ID	<t4d2P-3w5-35@gated-at.bofh.it> (permalink)
References	<t4d2P-3w5-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

of_match_device could return NULL, and so can cause a NULL
pointer dereference later.

Signed-off-by: Shailendra Verma <shailendra.v@samsung.com>
---
 drivers/misc/eeprom/eeprom_93xx46.c |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/misc/eeprom/eeprom_93xx46.c b/drivers/misc/eeprom/eeprom_93xx46.c
index 94cc035..6555975 100644
--- a/drivers/misc/eeprom/eeprom_93xx46.c
+++ b/drivers/misc/eeprom/eeprom_93xx46.c
@@ -381,6 +381,11 @@ static int eeprom_93xx46_probe_dt(struct spi_device *spi)
 	enum of_gpio_flags of_flags;
 	int ret;
 
+	if (!of_id) {
+		dev_err(&spi->dev, "Error: No device match found\n");
+		return -ENODEV;
+	}
+
 	pd = devm_kzalloc(&spi->dev, sizeof(*pd), GFP_KERNEL);
 	if (!pd)
 		return -ENOMEM;
-- 
1.7.9.5

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] Misc: eeprom - Fix possible NULL derefrence. Shailendra Verma <shailendra.v@samsung.com> - 2017-01-27 12:40 +0100

csiph-web