Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1569722
| From | Kishon Vijay Abraham I <kishon@ti.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 07/14] phy: qcom-ufs: Don't kfree devres resource |
| Date | 2017-01-30 14:10 +0100 |
| Message-ID | <t5jSy-4oc-17@gated-at.bofh.it> (permalink) |
| References | <t5iMN-3x0-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Bjorn Andersson <bjorn.andersson@linaro.org>
Upon failing to acquire regulator supplies the qcom-ufs driver calls
kfree() on the devm allocated memory used to store the name of the
regulator, leading to devres corruption.
Rather than switching to using the appropriate free function the patch
acknowledge the fact that "name" is always a constant string and we
don't actually need to create a local copy of it, but rather just
reference the constant string.
Fixes: add78fc05702 ("phy: qcom-ufs: Use devm sibling of kstrdup for regulator names")
Cc: stable@vger.kernel.org
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
drivers/phy/phy-qcom-ufs.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/phy/phy-qcom-ufs.c b/drivers/phy/phy-qcom-ufs.c
index c69568b..4d7f3c0 100644
--- a/drivers/phy/phy-qcom-ufs.c
+++ b/drivers/phy/phy-qcom-ufs.c
@@ -217,12 +217,7 @@ static int __ufs_qcom_phy_init_vreg(struct device *dev,
char prop_name[MAX_PROP_NAME];
- vreg->name = devm_kstrdup(dev, name, GFP_KERNEL);
- if (!vreg->name) {
- err = -ENOMEM;
- goto out;
- }
-
+ vreg->name = name;
vreg->reg = devm_regulator_get(dev, name);
if (IS_ERR(vreg->reg)) {
err = PTR_ERR(vreg->reg);
@@ -265,8 +260,6 @@ static int __ufs_qcom_phy_init_vreg(struct device *dev,
}
out:
- if (err)
- kfree(vreg->name);
return err;
}
--
1.7.9.5
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[GIT PULL] phy: for 4.11 Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100 [PATCH 10/15] phy: qcom-ufs: Remove -always-on property Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100 [PATCH 02/15] phy: sun4i-usb: add support for V3s USB PHY Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100 [PATCH 05/14] phy: Add support for Qualcomm's USB HSIC phy Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100 [PATCH 14/14] phy: qcom-ufs: Fix misplaced jump label Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100 [PATCH 03/14] phy: sun4i-usb: Replace the deprecated extcon API Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100 [PATCH 13/14] phy: fix rockchip-inno-usb2 build errors Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100 [PATCH 03/15] phy: rcar-gen3-usb2: Replace the deprecated extcon API Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100 [PATCH 10/14] phy: qcom-ufs: Suppress extraneous logging Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100 [PATCH 01/15] phy: rockchip-inno-usb2: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100 [PATCH 14/15] phy: fix rockchip-inno-usb2 build errors Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100 [PATCH 04/15] phy: sun4i-usb: Replace the deprecated extcon API Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100 [PATCH 15/15] phy: qcom-ufs: Fix misplaced jump label Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100 [PATCH 13/15] phy: Add USB3 PHY support for Broadcom NSP SoC Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100 [PATCH 12/15] dt-bindings: phy: Add documentation for NSP USB3 PHY Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100 [PATCH 02/14] phy: rcar-gen3-usb2: Replace the deprecated extcon API Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100 [PATCH 11/14] dt-bindings: phy: Add documentation for NSP USB3 PHY Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100 [PATCH 11/15] phy: qcom-ufs: Suppress extraneous logging Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:10 +0100 [PATCH 04/14] drivers: phy: constify phy_ops structures Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:10 +0100 [PATCH 01/14] phy: sun4i-usb: add support for V3s USB PHY Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:10 +0100 [PATCH 12/14] phy: Add USB3 PHY support for Broadcom NSP SoC Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:10 +0100 [PATCH 05/15] drivers: phy: constify phy_ops structures Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:10 +0100 [PATCH 07/14] phy: qcom-ufs: Don't kfree devres resource Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 14:10 +0100 [PATCH 09/14] phy: qcom-ufs: Remove -always-on property Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 14:40 +0100 [PATCH 09/15] phy: qcom-ufs: Correct usage of regulator_get() Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 15:20 +0100 [PATCH 06/14] phy: Add support for Qualcomm's USB HS phy Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 15:20 +0100 [PATCH 06/15] phy: Add support for Qualcomm's USB HSIC phy Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 15:20 +0100 [PATCH 07/15] phy: Add support for Qualcomm's USB HS phy Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 15:20 +0100 [PATCH 08/15] phy: qcom-ufs: Don't kfree devres resource Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 17:00 +0100 Re: [GIT PULL] phy: for 4.11 Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-31 11:10 +0100 Re: [GIT PULL] phy: for 4.11 Greg KH <gregkh@linuxfoundation.org> - 2017-01-31 11:10 +0100
csiph-web