Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1569656

[PATCH 14/15] phy: fix rockchip-inno-usb2 build errors

From Kishon Vijay Abraham I <kishon@ti.com>
Newsgroups linux.kernel
Subject [PATCH 14/15] phy: fix rockchip-inno-usb2 build errors
Date 2017-01-30 13:00 +0100
Message-ID <t5iMP-3x0-59@gated-at.bofh.it> (permalink)
References <t5iMN-3x0-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Randy Dunlap <rdunlap@infradead.org>

Fix build errors in phy-rockchip-inno-usb2.c. The driver uses
extcon interfaces so it should depend on EXTCON.

Fixes these build errors:

drivers/built-in.o: In function `rockchip_usb2phy_otg_sm_work':
phy-rockchip-inno-usb2.c:(.text+0x2bcb): undefined reference to `extcon_get_state'
phy-rockchip-inno-usb2.c:(.text+0x2cd4): undefined reference to `extcon_set_state_sync'
phy-rockchip-inno-usb2.c:(.text+0x2cec): undefined reference to `extcon_set_state_sync'
phy-rockchip-inno-usb2.c:(.text+0x2d2d): undefined reference to `extcon_get_state'
drivers/built-in.o: In function `rockchip_usb2phy_probe':
phy-rockchip-inno-usb2.c:(.text+0x31d7): undefined reference to `extcon_get_edev_by_phandle'
phy-rockchip-inno-usb2.c:(.text+0x321a): undefined reference to `devm_extcon_dev_allocate'
phy-rockchip-inno-usb2.c:(.text+0x3230): undefined reference to `devm_extcon_dev_register'
phy-rockchip-inno-usb2.c:(.text+0x375a): undefined reference to `extcon_register_notifier'

Found in linux-next but is also needed in mainline.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>
Cc: Heiko Stuebner <heiko@sntech.de>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 drivers/phy/Kconfig |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index eff994d..bb5cf6f 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -363,6 +363,7 @@ config PHY_ROCKCHIP_INNO_USB2
 	tristate "Rockchip INNO USB2PHY Driver"
 	depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF
 	depends on COMMON_CLK
+	depends on EXTCON
 	depends on USB_SUPPORT
 	select GENERIC_PHY
 	select USB_COMMON
-- 
1.7.9.5

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[GIT PULL] phy: for 4.11 Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100
  [PATCH 10/15] phy: qcom-ufs: Remove -always-on property Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100
  [PATCH 02/15] phy: sun4i-usb: add support for V3s USB PHY Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100
  [PATCH 05/14] phy: Add support for Qualcomm's USB HSIC phy Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100
  [PATCH 14/14] phy: qcom-ufs: Fix misplaced jump label Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100
  [PATCH 03/14] phy: sun4i-usb: Replace the deprecated extcon API Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100
  [PATCH 13/14] phy: fix rockchip-inno-usb2 build errors Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100
  [PATCH 03/15] phy: rcar-gen3-usb2: Replace the deprecated extcon API Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100
  [PATCH 10/14] phy: qcom-ufs: Suppress extraneous logging Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100
  [PATCH 01/15] phy: rockchip-inno-usb2: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100
  [PATCH 14/15] phy: fix rockchip-inno-usb2 build errors Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100
  [PATCH 04/15] phy: sun4i-usb: Replace the deprecated extcon API Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100
  [PATCH 15/15] phy: qcom-ufs: Fix misplaced jump label Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100
  [PATCH 13/15] phy: Add USB3 PHY support for Broadcom NSP SoC Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100
  [PATCH 12/15] dt-bindings: phy: Add documentation for NSP USB3 PHY Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100
  [PATCH 02/14] phy: rcar-gen3-usb2: Replace the deprecated extcon API Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100
  [PATCH 11/14] dt-bindings: phy: Add documentation for NSP USB3 PHY Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:00 +0100
  [PATCH 11/15] phy: qcom-ufs: Suppress extraneous logging Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:10 +0100
  [PATCH 04/14] drivers: phy: constify phy_ops structures Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:10 +0100
  [PATCH 01/14] phy: sun4i-usb: add support for V3s USB PHY Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:10 +0100
  [PATCH 12/14] phy: Add USB3 PHY support for Broadcom NSP SoC Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:10 +0100
  [PATCH 05/15] drivers: phy: constify phy_ops structures Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 13:10 +0100
  [PATCH 07/14] phy: qcom-ufs: Don't kfree devres resource Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 14:10 +0100
  [PATCH 09/14] phy: qcom-ufs: Remove -always-on property Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 14:40 +0100
  [PATCH 09/15] phy: qcom-ufs: Correct usage of regulator_get() Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 15:20 +0100
  [PATCH 06/14] phy: Add support for Qualcomm's USB HS phy Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 15:20 +0100
  [PATCH 06/15] phy: Add support for Qualcomm's USB HSIC phy Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 15:20 +0100
  [PATCH 07/15] phy: Add support for Qualcomm's USB HS phy Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 15:20 +0100
  [PATCH 08/15] phy: qcom-ufs: Don't kfree devres resource Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-30 17:00 +0100
  Re: [GIT PULL] phy: for 4.11 Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-31 11:10 +0100
  Re: [GIT PULL] phy: for 4.11 Greg KH <gregkh@linuxfoundation.org> - 2017-01-31 11:10 +0100

csiph-web