Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1571362

Re: [PATCH 2/3] drm/etnaviv: Update etnaviv_gem_fault() declaration to match definition.

Show all headers | View raw

Hi Liviu,

Am Dienstag, den 31.01.2017, 18:58 +0000 schrieb Liviu Dudau:
> Commit 25d3db7600b8 ("mm, fs: reduce fault, page_mkwrite, and pfn_mkwrite
> to take only vmf") updated the etnaviv_gem_fault() function signature
> without updating the header file with the declaration.
> 
There is already a patch from Arnd on the list that fixes this issue.

https://lkml.org/lkml/2017/1/25/718

Regards,
Lucas

> Fixes: 25d3db7600b8 ("mm, fs: reduce fault, page_mkwrite, and pfn_mkwrite to take only vmf")
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Russell King <linux+etnaviv@armlinux.org.uk>
> Cc: Christian Gmeiner <christian.gmeiner@gmail.com>
> Signed-off-by: Liviu Dudau <liviu@dudau.co.uk>
> ---
>  drivers/gpu/drm/etnaviv/etnaviv_drv.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.h b/drivers/gpu/drm/etnaviv/etnaviv_drv.h
> index c255eda40526..e41f38667c1c 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.h
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.h
> @@ -73,7 +73,7 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data,
>  		struct drm_file *file);
>  
>  int etnaviv_gem_mmap(struct file *filp, struct vm_area_struct *vma);
> -int etnaviv_gem_fault(struct vm_area_struct *vma, struct vm_fault *vmf);
> +int etnaviv_gem_fault(struct vm_fault *vmf);
>  int etnaviv_gem_mmap_offset(struct drm_gem_object *obj, u64 *offset);
>  struct sg_table *etnaviv_gem_prime_get_sg_table(struct drm_gem_object *obj);
>  void *etnaviv_gem_prime_vmap(struct drm_gem_object *obj);

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/3] drm/etnaviv: Update etnaviv_gem_fault() declaration to match definition. Liviu Dudau <liviu@dudau.co.uk> - 2017-01-31 20:10 +0100
  Re: [PATCH 2/3] drm/etnaviv: Update etnaviv_gem_fault() declaration  to match definition. Lucas Stach <l.stach@pengutronix.de> - 2017-02-01 10:30 +0100
    Re: [PATCH 2/3] drm/etnaviv: Update etnaviv_gem_fault() declaration  to match definition. Liviu Dudau <Liviu.Dudau@arm.com> - 2017-02-01 10:50 +0100

csiph-web