Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1571361

[PATCH 3/3] vmalloc: back of when the current is killed

Show all headers | View raw

From: Michal Hocko <mhocko@suse.com>

__vmalloc_area_node allocates pages to cover the requested vmalloc size.
This can be a lot of memory. If the current task is killed by the OOM
killer, and thus has an unlimited access to memory reserves, it can
consume all the memory theoretically. Fix this by checking for
fatal_signal_pending and back off early.

Signed-off-by: Michal Hocko <mhocko@suse.com>
---
 mm/vmalloc.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index d89034a393f2..011b446f8758 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -1642,6 +1642,11 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask,
 	for (i = 0; i < area->nr_pages; i++) {
 		struct page *page;
 
+		if (fatal_signal_pending(current)) {
+			area->nr_pages = i;
+			goto fail;
+		}
+
 		if (node == NUMA_NO_NODE)
 			page = alloc_page(alloc_mask);
 		else
-- 
2.11.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] fix few OOM victim allocation runaways Michal Hocko <mhocko@kernel.org> - 2017-02-01 10:30 +0100
  Re: [PATCH 1/3] fs: break out of iomap_file_buffered_write on         fatal signals Christoph Hellwig <hch@lst.de> - 2017-02-01 10:30 +0100
  [PATCH 3/3] vmalloc: back of when the current is killed Michal Hocko <mhocko@kernel.org> - 2017-02-01 10:30 +0100
  [PATCH 2/3] mm, fs: check for fatal signals in do_generic_file_read Michal Hocko <mhocko@kernel.org> - 2017-02-01 10:30 +0100
  [PATCH 1/3] fs: break out of iomap_file_buffered_write on fatal signals Michal Hocko <mhocko@kernel.org> - 2017-02-01 10:30 +0100
  Re: [PATCH 0/3] fix few OOM victim allocation runaways Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2017-02-01 13:00 +0100

csiph-web