Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1570796
| From | Will Deacon <will.deacon@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v5 2/2] arm64: Work around Falkor erratum 1009 |
| Date | 2017-01-31 15:50 +0100 |
| Message-ID | <t5HUS-1S1-17@gated-at.bofh.it> (permalink) |
| References | <t5tfb-1B3-7@gated-at.bofh.it> <t5tfb-1B3-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Jan 30, 2017 at 06:08:17PM -0500, Christopher Covington wrote:
> diff --git a/arch/arm64/include/asm/tlbflush.h b/arch/arm64/include/asm/tlbflush.h
> index deab52374119..fc434f421c7b 100644
> --- a/arch/arm64/include/asm/tlbflush.h
> +++ b/arch/arm64/include/asm/tlbflush.h
> @@ -36,9 +36,21 @@
> * not. The macros handles invoking the asm with or without the
> * register argument as appropriate.
> */
> -#define __TLBI_0(op, arg) asm ("tlbi " #op)
> -#define __TLBI_1(op, arg) asm ("tlbi " #op ", %0" : : "r" (arg))
> -#define __TLBI_N(op, arg, n, ...) __TLBI_##n(op, arg)
> +#define __TLBI_0(op, arg) asm volatile ("tlbi " #op "\n" \
> + ALTERNATIVE("nop\n nop", \
> + "dsb ish\n tlbi " #op, \
> + ARM64_WORKAROUND_REPEAT_TLBI, \
> + CONFIG_QCOM_FALKOR_ERRATUM_1009) \
> + : : )
> +
> +#define __TLBI_1(op, arg) asm volatile ("tlbi " #op ", %0\n" \
> + ALTERNATIVE("nop\n nop", \
> + "dsb ish\n tlbi " #op ", %0", \
> + ARM64_WORKAROUND_REPEAT_TLBI, \
> + CONFIG_QCOM_FALKOR_ERRATUM_1009) \
> + : : "r" (arg))
> +
Why are these now volatile? I asked the same question on the previous
version but didn't get a response:
http://lists.infradead.org/pipermail/linux-arm-kernel/2017-January/483579.html
Will
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v5 2/2] arm64: Work around Falkor erratum 1009 Christopher Covington <cov@codeaurora.org> - 2017-01-31 00:10 +0100
Re: [PATCH v5 2/2] arm64: Work around Falkor erratum 1009 Mark Rutland <mark.rutland@arm.com> - 2017-01-31 13:50 +0100
Re: [PATCH v5 2/2] arm64: Work around Falkor erratum 1009 Will Deacon <will.deacon@arm.com> - 2017-01-31 15:40 +0100
Re: [PATCH v5 2/2] arm64: Work around Falkor erratum 1009 Will Deacon <will.deacon@arm.com> - 2017-01-31 15:50 +0100
Re: [PATCH v5 2/2] arm64: Work around Falkor erratum 1009 Christopher Covington <cov@codeaurora.org> - 2017-01-31 17:20 +0100
csiph-web