Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1568868

Re: [PATCH] i2c: piix4: Fix request_region size

From Jean Delvare <jdelvare@suse.de>
Newsgroups linux.kernel
Subject Re: [PATCH] i2c: piix4: Fix request_region size
Date 2017-01-28 12:20 +0100
Message-ID <t4zcZ-Gf-5@gated-at.bofh.it> (permalink)
References <t4gtI-5Mm-23@gated-at.bofh.it> <t4wI9-7pN-5@gated-at.bofh.it> <t4z3j-CN-5@gated-at.bofh.it>
Organization SUSE Linux

Show all headers | View raw


Hi Wolfram,

On Sat, 28 Jan 2017 12:00:21 +0100, Wolfram Sang wrote:
> 
> > >  /* count for request_region */
> > > -#define SMBIOSIZE	8
> > > +#define SMBIOSIZE	9
> > 
> > Are you certain that all supported devices have this extra register?
> 
> Isn't it better to have a potentially unused register mapped than a
> potentially used register unmapped?

My concern is that the region request could fail due to a conflict with
another device, if the physical I/O region is only 8 and we try to
request 9.

-- 
Jean Delvare
SUSE L3 Support

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] i2c: piix4: Fix request_region size Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2017-01-27 16:20 +0100
  Re: [PATCH] i2c: piix4: Fix request_region size Jean Delvare <jdelvare@suse.de> - 2017-01-28 09:40 +0100
    Re: [PATCH] i2c: piix4: Fix request_region size Wolfram Sang <wsa@the-dreams.de> - 2017-01-28 12:10 +0100
      Re: [PATCH] i2c: piix4: Fix request_region size Jean Delvare <jdelvare@suse.de> - 2017-01-28 12:20 +0100
        Re: [PATCH] i2c: piix4: Fix request_region size Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2017-01-30 02:20 +0100

csiph-web