Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1568848

Re: [PATCH] i2c: piix4: Fix request_region size

Show all headers | View raw

Hi Ricardo,

On ven., 2017-01-27 at 15:59 +0100, Ricardo Ribalda Delgado wrote:
> Since '701dc207bf55 ("i2c: piix4: Avoid race conditions with IMC")'
> we
> are using the SMBSLVCNT register at offset 0x8. We need to request
> it.
> 
> Fixes: 701dc207bf55 ("i2c: piix4: Avoid race conditions with IMC")
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> ---
> Please note, not tested on hardware.
>  drivers/i2c/busses/i2c-piix4.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-
> piix4.c
> index e34d82e79b98..73cc6799cc59 100644
> --- a/drivers/i2c/busses/i2c-piix4.c
> +++ b/drivers/i2c/busses/i2c-piix4.c
> @@ -58,7 +58,7 @@
>  #define SMBSLVDAT	(0xC + piix4_smba)
>  
>  /* count for request_region */
> -#define SMBIOSIZE	8
> +#define SMBIOSIZE	9
> 

Are you certain that all supported devices have this extra register?

>  
>  /* PCI Address Constants */
>  #define SMBBA		0x090

-- 
Jean Delvare
SUSE L3 Support

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] i2c: piix4: Fix request_region size Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2017-01-27 16:20 +0100
  Re: [PATCH] i2c: piix4: Fix request_region size Jean Delvare <jdelvare@suse.de> - 2017-01-28 09:40 +0100
    Re: [PATCH] i2c: piix4: Fix request_region size Wolfram Sang <wsa@the-dreams.de> - 2017-01-28 12:10 +0100
      Re: [PATCH] i2c: piix4: Fix request_region size Jean Delvare <jdelvare@suse.de> - 2017-01-28 12:20 +0100
        Re: [PATCH] i2c: piix4: Fix request_region size Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2017-01-30 02:20 +0100

csiph-web