Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1568557

[PATCH v2 01/10] serial: st-asc: Ignore the parity error bit if 8-bit mode is enabled

Show all headers | View raw

The datasheet states:

"If the MODE field selects an 8-bit frame then this [parity error] bit
 is undefined. Software should ignore this bit when reading 8-bit frames."

Acked-by: Peter Griffin <peter.griffin@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/tty/serial/st-asc.c | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c
index 379e5bd..69e6232 100644
--- a/drivers/tty/serial/st-asc.c
+++ b/drivers/tty/serial/st-asc.c
@@ -287,9 +287,19 @@ static void asc_transmit_chars(struct uart_port *port)
 static void asc_receive_chars(struct uart_port *port)
 {
 	struct tty_port *tport = &port->state->port;
-	unsigned long status;
+	unsigned long status, mode;
 	unsigned long c = 0;
 	char flag;
+	bool ignore_pe = false;
+
+	/*
+	 * Datasheet states: If the MODE field selects an 8-bit frame then
+	 * this [parity error] bit is undefined. Software should ignore this
+	 * bit when reading 8-bit frames.
+	 */
+	mode = asc_in(port, ASC_CTL) & ASC_CTL_MODE_MSK;
+	if (mode == ASC_CTL_MODE_8BIT || mode == ASC_CTL_MODE_8BIT_PAR)
+		ignore_pe = true;
 
 	if (port->irq_wake)
 		pm_wakeup_event(tport->tty->dev, 0);
@@ -299,8 +309,8 @@ static void asc_receive_chars(struct uart_port *port)
 		flag = TTY_NORMAL;
 		port->icount.rx++;
 
-		if ((c & (ASC_RXBUF_FE | ASC_RXBUF_PE)) ||
-			status & ASC_STA_OE) {
+		if (status & ASC_STA_OE || c & ASC_RXBUF_FE ||
+		    (c & ASC_RXBUF_PE && !ignore_pe)) {
 
 			if (c & ASC_RXBUF_FE) {
 				if (c == (ASC_RXBUF_FE | ASC_RXBUF_DUMMY_RX)) {
-- 
2.9.3

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 00/10] serial: st-asc: Allow handling of RTS line Lee Jones <lee.jones@linaro.org> - 2017-01-27 18:30 +0100
  [PATCH v2 03/10] serial: st-asc: Read in all Pinctrl states Lee Jones <lee.jones@linaro.org> - 2017-01-27 18:30 +0100
  [PATCH v2 06/10] dt-bindings: serial: Update 'uart-has-rtscts' description Lee Jones <lee.jones@linaro.org> - 2017-01-27 18:30 +0100
  [PATCH v2 02/10] serial: st-asc: Provide RTS functionality Lee Jones <lee.jones@linaro.org> - 2017-01-27 18:30 +0100
  [PATCH v2 09/10] ARM: dts: STiH407-family: Use new Pinctrl groups Lee Jones <lee.jones@linaro.org> - 2017-01-27 18:40 +0100
    Re: [PATCH v2 09/10] ARM: dts: STiH407-family: Use new Pinctrl groups Patrice CHOTARD <patrice.chotard@st.com> - 2017-01-30 12:10 +0100
  [PATCH v2 04/10] serial: st-asc: (De)Register GPIOD and swap Pinctrl profiles Lee Jones <lee.jones@linaro.org> - 2017-01-27 18:40 +0100
  [PATCH v2 10/10] ARM: dts: STiH410-b2260: Enable HW flow-control Lee Jones <lee.jones@linaro.org> - 2017-01-27 18:40 +0100
  [PATCH v2 08/10] ARM: dts: STiH407-pinctrl: Add Pinctrl group for HW flow-control Lee Jones <lee.jones@linaro.org> - 2017-01-27 18:40 +0100
  [PATCH v2 05/10] serial: st-asc: Use generic DT binding for announcing RTS/CTS lines Lee Jones <lee.jones@linaro.org> - 2017-01-27 18:40 +0100
  [PATCH v2 01/10] serial: st-asc: Ignore the parity error bit if 8-bit mode is enabled Lee Jones <lee.jones@linaro.org> - 2017-01-27 18:40 +0100
  [PATCH v2 07/10] ARM: dts: STiH410-b2260: Identify the UART RTS line Lee Jones <lee.jones@linaro.org> - 2017-01-27 18:40 +0100

csiph-web