Re: [PATCH] greybus: Fix coding stye error

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] greybus: Fix coding stye error
Date	2017-01-27 14:30 +0100
Message-ID	<t4eLf-4FD-3@gated-at.bofh.it> (permalink)
References	<t4bNo-2Pk-17@gated-at.bofh.it> <t4dYR-49I-1@gated-at.bofh.it> <t4eBz-4C9-3@gated-at.bofh.it> <t4eBz-4C9-5@gated-at.bofh.it> <t4eBz-4C9-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jan 27, 2017 at 02:08:06PM +0100, Johan Hovold wrote:
> On Fri, Jan 27, 2017 at 03:47:21PM +0300, Dan Carpenter wrote:
> > The name sucks is what I'm saying.  Please fix it eventually.
> 
> I disagree. The name uses a common prefix that reflects the object it is
> working on. This should not be changed. As it is currently named, the
> function is also self-documenting. Trying to abbreviate the name just to
> meet a 80 col limit (when there are alternatives) is just silly.

gb_interface_request_mode_switch()

It's not self documenting because there are no verbs in that sentence.
I guess in JAVA it would be considered good style.

This is "Enterprise Quality" in the derogatory sense of the term.  The
prefix makes everything too long and doesn't add any value.  We don't
keep the 80 character limit because of small screens, we keep it to
discourage this type of code.

regards,
dan carpenter

Thread

[PATCH] greybus: Fix coding stye error mrossibellom@gmail.com - 2017-01-27 11:20 +0100
  Re: [PATCH] greybus: Fix coding stye error Greg KH <gregkh@linuxfoundation.org> - 2017-01-27 11:30 +0100
  Re: [PATCH] greybus: Fix coding stye error Dan Carpenter <dan.carpenter@oracle.com> - 2017-01-27 13:40 +0100
    Re: [PATCH] greybus: Fix coding stye error Johan Hovold <johan@kernel.org> - 2017-01-27 14:20 +0100
      Re: [PATCH] greybus: Fix coding stye error Dan Carpenter <dan.carpenter@oracle.com> - 2017-01-27 14:30 +0100
        Re: [PATCH] greybus: Fix coding stye error Johan Hovold <johan@kernel.org> - 2017-01-27 15:10 +0100
          Re: [PATCH] greybus: Fix coding stye error Dan Carpenter <dan.carpenter@oracle.com> - 2017-01-27 15:20 +0100
            Re: [PATCH] greybus: Fix coding stye error Maxime Rossi Bellom <mrossibellom@gmail.com> - 2017-01-27 15:40 +0100
              Re: [PATCH] greybus: Fix coding stye error Maxime Rossi Bellom <mrossibellom@gmail.com> - 2017-01-27 15:50 +0100
              Re: [PATCH] greybus: Fix coding stye error Dan Carpenter <dan.carpenter@oracle.com> - 2017-01-27 15:50 +0100
    Re: [PATCH] greybus: Fix coding stye error Johan Hovold <johan@kernel.org> - 2017-01-27 14:40 +0100
      Re: [PATCH] greybus: Fix coding stye error Dan Carpenter <dan.carpenter@oracle.com> - 2017-01-27 15:20 +0100

csiph-web