Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1568329

Re: [PATCH] greybus: Fix coding stye error

Show all headers | View raw

On Fri, Jan 27, 2017 at 11:11:21AM +0100, mrossibellom@gmail.com wrote:
> From: Maxime Rossi Bellom <mrossibellom@gmail.com>
> 
> Split line before funtion argument.
> 
> Error was reported by checkpatch.pl as
> WARNING: line over 80 characters
> 
> Signed-off-by: Maxime Rossi Bellom <mrossibellom@gmail.com>
> ---
>  drivers/staging/greybus/fw-management.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/fw-management.c b/drivers/staging/greybus/fw-management.c
> index 3cd6cf0..d88117e 100644
> --- a/drivers/staging/greybus/fw-management.c
> +++ b/drivers/staging/greybus/fw-management.c
> @@ -516,7 +516,8 @@ static int fw_mgmt_ioctl(struct fw_mgmt *fw_mgmt, unsigned int cmd,
>  		 */
>  		fw_mgmt->mode_switch_started = true;
>  
> -		ret = gb_interface_request_mode_switch(fw_mgmt->connection->intf);
> +		ret = gb_interface_request_mode_switch(
> +				fw_mgmt->connection->intf);


Another option would be to change the name from
gb_interface_request_mode_switch() to gb_get_mode_switch() or something
along those lines.  It requires understanding the code to say what a
good name is.

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] greybus: Fix coding stye error mrossibellom@gmail.com - 2017-01-27 11:20 +0100
  Re: [PATCH] greybus: Fix coding stye error Greg KH <gregkh@linuxfoundation.org> - 2017-01-27 11:30 +0100
  Re: [PATCH] greybus: Fix coding stye error Dan Carpenter <dan.carpenter@oracle.com> - 2017-01-27 13:40 +0100
    Re: [PATCH] greybus: Fix coding stye error Johan Hovold <johan@kernel.org> - 2017-01-27 14:20 +0100
      Re: [PATCH] greybus: Fix coding stye error Dan Carpenter <dan.carpenter@oracle.com> - 2017-01-27 14:30 +0100
        Re: [PATCH] greybus: Fix coding stye error Johan Hovold <johan@kernel.org> - 2017-01-27 15:10 +0100
          Re: [PATCH] greybus: Fix coding stye error Dan Carpenter <dan.carpenter@oracle.com> - 2017-01-27 15:20 +0100
            Re: [PATCH] greybus: Fix coding stye error Maxime Rossi Bellom <mrossibellom@gmail.com> - 2017-01-27 15:40 +0100
              Re: [PATCH] greybus: Fix coding stye error Maxime Rossi Bellom <mrossibellom@gmail.com> - 2017-01-27 15:50 +0100
              Re: [PATCH] greybus: Fix coding stye error Dan Carpenter <dan.carpenter@oracle.com> - 2017-01-27 15:50 +0100
    Re: [PATCH] greybus: Fix coding stye error Johan Hovold <johan@kernel.org> - 2017-01-27 14:40 +0100
      Re: [PATCH] greybus: Fix coding stye error Dan Carpenter <dan.carpenter@oracle.com> - 2017-01-27 15:20 +0100

csiph-web