Re: [PATCH] nvdimm: constify device_type structures

Path	csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Bhumika Goyal <bhumirks@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] nvdimm: constify device_type structures
Date	Wed, 25 Jan 2017 17:20:01 +0100
Message-ID	<t3ysF-403-9@gated-at.bofh.it> (permalink)
References	<t3eWZ-8j5-1@gated-at.bofh.it> <t3lF7-4at-7@gated-at.bofh.it> <t3lON-4dZ-7@gated-at.bofh.it> <t3lON-4dZ-9@gated-at.bofh.it> <t3pz3-6Kn-1@gated-at.bofh.it> <t3yiZ-3WA-23@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ljhrLld6TOj67yUG67HUTR4AmRIBXAFNcpn1qBAbAJo=; b=UastTBpaLbk9/0J/PcqHvOrEIpK9gnWKW8TRsBaC55ofIUnj7dGiblzA5T+Myuj99N h6lfzmxOixH6SBKkwLvgHTvMG7hxkhy82JcmfwOmD1jMbo3+o52KhN597yQeqhK2O3dE tidpkGVXjXQ7eJaxCiIygyGNnYd3REMyrdCg0MH472BGhnKd6tbY16GuLR1SUA21uHYo xJK+H108zfAEtoUkj54VQjU+HfKRWFvVykvyuhFtIwylaUf4RgliTM2f8j5iYJOAODq0 GV5MOwV7OqkmqSU60nXPbSlACIn13Uxcwg5BowZ2mIaxwQ6/MkWUU45i2u3mBiwIoIle qNUw==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ljhrLld6TOj67yUG67HUTR4AmRIBXAFNcpn1qBAbAJo=; b=lfs6mS4gRC1dwLwbAs5AAg+HmGrF5DmiSNkFjkGJBER5pkGFBDZfvHE6nRs+LhUM+/ PGLw5p4YHDiNdcw52Sd+fDvzzfCH89O6RoV+2RWeuhIpsmN4lZ+bbDW37aKQxTrRnYoU NE1p4qbrW6YEQKuwuGq+hR+tMZYf/GEnKjpAjgUfpe2J3F88fMUL9ygYvsuTiYeEDHIT wljXEeR8xvIkIMrBnPCEhTcw2LJi+6JRMCJsAQZSd0/HvL7kN6kUceIOECvx4eOfuMD0 Scp5QtMSTaeaK0/zElyFm+/KgxoS7phq4S0wP4soNljD9dvgya5kl8igwr8SCeN1kL3O xP9A==
X-Gm-Message-State	AIkVDXIW2Ol/uPb7ysLpbP4zJXtB6Isf7WlQ8Yqzj7X3WgmnecMukophI8L0z5LfMH4jgmUbj8lhrOi9/BG4yw==
X-Received	by 10.107.136.31 with SMTP id k31mr34931768iod.112.1485361005609; Wed, 25 Jan 2017 08:16:45 -0800 (PST)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	35
Organization	linux.* mail to news gateway
X-Original-Cc	Julia Lawall <julia.lawall@lip6.fr>, Dan Williams <dan.j.williams@intel.com>, "linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
X-Original-Date	Wed, 25 Jan 2017 21:46:45 +0530
X-Original-Message-ID	<CAOH+1jE5F_2qL2O_iMo69y5rpTmSq-1eOKTas6_xuP8xitfWbw@mail.gmail.com>
X-Original-References	<1485285847-7006-1-git-send-email-bhumirks@gmail.com> <1485311842.12563.50.camel@perches.com> <CAPcyv4i7-vT+-VqU2n4bxrtcwrYtJ5rcVg3=bf5gCx-YRe3HkA@mail.gmail.com> <1485312569.12563.52.camel@perches.com> <alpine.DEB.2.20.1701250745340.2011@hadrien> <1485360117.12563.85.camel@perches.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1566716

Show key headers only | View raw

On Wed, Jan 25, 2017 at 9:31 PM, Joe Perches <joe@perches.com> wrote:
> On Wed, 2017-01-25 at 07:49 +0100, Julia Lawall wrote:
>> What does the data column actually represent?  I tried size on the .o file
>> generated from:
>>
>> commit a65f0161f4d69d6738d4821e649448312cd818e2
>> Author: Stephen Rothwell <sfr@canb.auug.org.au>
>> Date:   Tue Jan 17 15:22:28 2017 +1100
>>
>> with CONFIG_X86_64=y and I get:
>>
>>    text          data     bss     dec     hex filename
>>   19726          3480      16   23222    5ab6 drivers/nvdimm/namespace_devs.o
>>
>> but when I run objdump -sh drivers/nvdimm/namespace_devs.o, I find a .data
>> segment of size 1008 and a .data.unlikely segment of size 8, which don't
>> match up with the results of size.
>
> Likely you have dynamic_debug enabled and you
> need to include these additional sections:
>
>         __jump_table
>         __verbose
>
> If user_mode_linux is enabled, add sections:
>
>         .fini_array
>         .init_array
>

Thanks for the explanation. I also compiled the patch for x86-64 but
couldn't find what went wrong but this solved the problem.

Thanks,
Bhumika

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] nvdimm: constify device_type structures Bhumika Goyal <bhumirks@gmail.com> - 2017-01-24 20:30 +0100
  Re: [PATCH] nvdimm: constify device_type structures Dan Williams <dan.j.williams@intel.com> - 2017-01-24 21:00 +0100
  Re: [PATCH] nvdimm: constify device_type structures Joe Perches <joe@perches.com> - 2017-01-25 03:40 +0100
    Re: [PATCH] nvdimm: constify device_type structures Dan Williams <dan.j.williams@intel.com> - 2017-01-25 03:50 +0100
      Re: [PATCH] nvdimm: constify device_type structures Joe Perches <joe@perches.com> - 2017-01-25 03:50 +0100
        Re: [PATCH] nvdimm: constify device_type structures Julia Lawall <julia.lawall@lip6.fr> - 2017-01-25 07:50 +0100
          Re: [PATCH] nvdimm: constify device_type structures Julia Lawall <julia.lawall@lip6.fr> - 2017-01-25 17:10 +0100
          Re: [PATCH] nvdimm: constify device_type structures Joe Perches <joe@perches.com> - 2017-01-25 17:10 +0100
            Re: [PATCH] nvdimm: constify device_type structures Bhumika Goyal <bhumirks@gmail.com> - 2017-01-25 17:20 +0100

csiph-web