Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1566291

Re: [PATCH] nvdimm: constify device_type structures

From Dan Williams <dan.j.williams@intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH] nvdimm: constify device_type structures
Date 2017-01-25 03:50 +0100
Message-ID <t3lON-4dZ-7@gated-at.bofh.it> (permalink)
References <t3eWZ-8j5-1@gated-at.bofh.it> <t3lF7-4at-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, Jan 24, 2017 at 6:37 PM, Joe Perches <joe@perches.com> wrote:
> On Wed, 2017-01-25 at 00:54 +0530, Bhumika Goyal wrote:
>> Declare device_type structure as const as it is only stored in the
>> type field of a device structure. This field is of type const, so add
>> const to declaration of device_type structure.
>>
>> File size before:
>>   text           data     bss     dec     hex filename
>>   19278          3199      16   22493    57dd nvdimm/namespace_devs.o
>>
>> File size after:
>>   text           data     bss     dec     hex filename
>>   19929          3160      16   23105    5a41 nvdimm/namespace_devs.o
>
> Fine, but are you sure about the sizes?
>
> It seems odd the text went up 651 bytes
> while the data went down just 39 bytes.
>

Right, the size data wasn't why I applied it. It was the general rule
of "make function pointer data read-only whenever possible to
eliminate a kernel attack vector".  Bhumika, you might want to mention
this as the motivating reason to apply the patch if you do more of
these changes.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] nvdimm: constify device_type structures Bhumika Goyal <bhumirks@gmail.com> - 2017-01-24 20:30 +0100
  Re: [PATCH] nvdimm: constify device_type structures Dan Williams <dan.j.williams@intel.com> - 2017-01-24 21:00 +0100
  Re: [PATCH] nvdimm: constify device_type structures Joe Perches <joe@perches.com> - 2017-01-25 03:40 +0100
    Re: [PATCH] nvdimm: constify device_type structures Dan Williams <dan.j.williams@intel.com> - 2017-01-25 03:50 +0100
      Re: [PATCH] nvdimm: constify device_type structures Joe Perches <joe@perches.com> - 2017-01-25 03:50 +0100
        Re: [PATCH] nvdimm: constify device_type structures Julia Lawall <julia.lawall@lip6.fr> - 2017-01-25 07:50 +0100
          Re: [PATCH] nvdimm: constify device_type structures Julia Lawall <julia.lawall@lip6.fr> - 2017-01-25 17:10 +0100
          Re: [PATCH] nvdimm: constify device_type structures Joe Perches <joe@perches.com> - 2017-01-25 17:10 +0100
            Re: [PATCH] nvdimm: constify device_type structures Bhumika Goyal <bhumirks@gmail.com> - 2017-01-25 17:20 +0100

csiph-web