Re: [PATCH v3] HWPOISON: soft offlining for non-lru movable page

From	Michal Hocko <mhocko@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] HWPOISON: soft offlining for non-lru movable page
Date	2017-01-25 13:00 +0100
Message-ID	<t3up3-1i3-5@gated-at.bofh.it> (permalink)
References	<t2Og9-7Iq-3@gated-at.bofh.it> <t3ufo-1eA-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed 25-01-17 12:47:53, Michal Hocko wrote:
> On Mon 23-01-17 22:50:10, ysxie@foxmail.com wrote:
> > From: Yisheng Xie <xieyisheng1@huawei.com>
> > 
> > This patch is to extends soft offlining framework to support
> > non-lru page, which already support migration after
> > commit bda807d44454 ("mm: migrate: support non-lru movable page
> > migration")
> > 
> > When memory corrected errors occur on a non-lru movable page,
> > we can choose to stop using it by migrating data onto another
> > page and disable the original (maybe half-broken) one.
> > 
> > Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
> > Suggested-by: Michal Hocko <mhocko@kernel.org>
> > Suggested-by: Minchan Kim <minchan@kernel.org>
> > Acked-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> 
> This doesn't compile with CONFIG_MIGRATION=n
> 
> mm/memory-failure.c: In function '__soft_offline_page':
> mm/memory-failure.c:1656:3: error: implicit declaration of function 'isolate_movable_page' [-Werror=implicit-function-declaration]
>    ret = !isolate_movable_page(page, ISOLATE_UNEVICTABLE);
>    ^
> cc1: some warnings being treated as errors

OK, I have missed
http://lkml.kernel.org/r/1485340563-60785-1-git-send-email-xieyisheng1@huawei.com
so please scratch this one.

-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3] HWPOISON: soft offlining for non-lru movable page ysxie@foxmail.com - 2017-01-23 16:00 +0100
  Re: [PATCH v3] HWPOISON: soft offlining for non-lru movable page Minchan Kim <minchan@kernel.org> - 2017-01-24 03:40 +0100
  Re: [PATCH v3] HWPOISON: soft offlining for non-lru movable page Michal Hocko <mhocko@kernel.org> - 2017-01-25 12:50 +0100
    Re: [PATCH v3] HWPOISON: soft offlining for non-lru movable page Michal Hocko <mhocko@kernel.org> - 2017-01-25 13:00 +0100

csiph-web