Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1566523

Re: [PATCH v3] HWPOISON: soft offlining for non-lru movable page

Show all headers | View raw

On Mon 23-01-17 22:50:10, ysxie@foxmail.com wrote:
> From: Yisheng Xie <xieyisheng1@huawei.com>
> 
> This patch is to extends soft offlining framework to support
> non-lru page, which already support migration after
> commit bda807d44454 ("mm: migrate: support non-lru movable page
> migration")
> 
> When memory corrected errors occur on a non-lru movable page,
> we can choose to stop using it by migrating data onto another
> page and disable the original (maybe half-broken) one.
> 
> Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
> Suggested-by: Michal Hocko <mhocko@kernel.org>
> Suggested-by: Minchan Kim <minchan@kernel.org>
> Acked-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>

This doesn't compile with CONFIG_MIGRATION=n

mm/memory-failure.c: In function '__soft_offline_page':
mm/memory-failure.c:1656:3: error: implicit declaration of function 'isolate_movable_page' [-Werror=implicit-function-declaration]
   ret = !isolate_movable_page(page, ISOLATE_UNEVICTABLE);
   ^
cc1: some warnings being treated as errors

I guess the following should handle the problem
---
diff --git a/include/linux/migrate.h b/include/linux/migrate.h
index ae8d475a9385..1da7a1f99fc7 100644
--- a/include/linux/migrate.h
+++ b/include/linux/migrate.h
@@ -57,6 +57,11 @@ static inline int migrate_pages(struct list_head *l, new_page_t new,
 		int reason)
 	{ return -ENOSYS; }
 
+static inline bool isolate_movable_page(struct page *page, isolate_mode_t mode)
+{
+	return -EBUSY;
+}
+
 static inline int migrate_prep(void) { return -ENOSYS; }
 static inline int migrate_prep_local(void) { return -ENOSYS; }
 
At least it compiles fine now. I have to look at the patch yet.
-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3] HWPOISON: soft offlining for non-lru movable page ysxie@foxmail.com - 2017-01-23 16:00 +0100
  Re: [PATCH v3] HWPOISON: soft offlining for non-lru movable page Minchan Kim <minchan@kernel.org> - 2017-01-24 03:40 +0100
  Re: [PATCH v3] HWPOISON: soft offlining for non-lru movable page Michal Hocko <mhocko@kernel.org> - 2017-01-25 12:50 +0100
    Re: [PATCH v3] HWPOISON: soft offlining for non-lru movable page Michal Hocko <mhocko@kernel.org> - 2017-01-25 13:00 +0100

csiph-web