Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1566248

Re: [PATCH] clk: samsung: mark s3c...._clk_sleep_init() as __init

Show all headers | View raw

Hi Martin,

On 2017년 01월 25일 06:33, Martin Kaiser wrote:
> These functions are called only by other __init functions.
> Compiling for s3c2410 with CONFIG_DEBUG_SECTION_MISMATCH=y,
> I get warnings like
> 
> WARNING: vmlinux.o(.text+0x198350):
> Section mismatch in reference from the function s3c2410_clk_sleep_init()
> to the (unknown reference) .init.data:(unknown)
> 
> Marking the s3c...._clk_sleep() functions as __init fixes this.
> 
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
>  drivers/clk/samsung/clk-s3c2410.c | 4 ++--
>  drivers/clk/samsung/clk-s3c2412.c | 4 ++--
>  drivers/clk/samsung/clk-s3c2443.c | 4 ++--
>  drivers/clk/samsung/clk-s3c64xx.c | 4 ++--
>  4 files changed, 8 insertions(+), 8 deletions(-)


Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

[snip]

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] clk: samsung: mark s3c...._clk_sleep_init() as __init Martin Kaiser <martin@kaiser.cx> - 2017-01-24 22:40 +0100
  Re: [PATCH] clk: samsung: mark s3c...._clk_sleep_init() as __init Chanwoo Choi <cw00.choi@samsung.com> - 2017-01-25 01:40 +0100
  Re: [PATCH] clk: samsung: mark s3c...._clk_sleep_init() as __init Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-25 09:40 +0100
  [PATCH v2] clk: samsung: mark s3c...._clk_sleep_init() as __init martin@kaiser.cx - 2017-01-25 22:50 +0100
    Re: [PATCH v2] clk: samsung: mark s3c...._clk_sleep_init() as __init Chanwoo Choi <cw00.choi@samsung.com> - 2017-01-26 00:50 +0100
    Re: [PATCH v2] clk: samsung: mark s3c...._clk_sleep_init() as __init Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-26 07:00 +0100
    Re: [PATCH v2] clk: samsung: mark s3c...._clk_sleep_init() as __init Stephen Boyd <sboyd@codeaurora.org> - 2017-01-27 01:40 +0100
      Re: [PATCH v2] clk: samsung: mark s3c...._clk_sleep_init() as __init Sylwester Nawrocki <s.nawrocki@samsung.com> - 2017-01-27 11:10 +0100

csiph-web